[Qemu-devel] [PATCH] i386: Return migration-safe field on query-cpu-definitions

[Qemu-devel] [PATCH] i386: Return migration-safe field on query-cpu-definitions

[Eduardo Habkost]

Return the migration-safe field on query-cpu-definitions. All CPU
models in x86 are migration-safe except "host".

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target/i386/cpu-qom.h | 2 ++
 target/i386/cpu.c     | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/target/i386/cpu-qom.h b/target/i386/cpu-qom.h
index 7c9a07ae65..8cd607e9a2 100644
--- a/target/i386/cpu-qom.h
+++ b/target/i386/cpu-qom.h
@@ -48,6 +48,7 @@ typedef struct X86CPUDefinition X86CPUDefinition;
  * X86CPUClass:
  * @cpu_def: CPU model definition
  * @kvm_required: Whether CPU model requires KVM to be enabled.
+ * @migration_safe: See CpuDefinitionInfo::migration_safe
  * @parent_realize: The parent class' realize handler.
  * @parent_reset: The parent class' reset handler.
  *
@@ -62,6 +63,7 @@ typedef struct X86CPUClass {
     X86CPUDefinition *cpu_def;
 
     bool kvm_required;
+    bool migration_safe;
 
     /* Optional description of CPU model.
      * If unavailable, cpu_def->model_id is used */
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 337636a96a..ec6eaf215c 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -2209,6 +2209,8 @@ static void x86_cpu_definition_entry(gpointer data, gpointer user_data)
     x86_cpu_class_check_missing_features(cc, &info->unavailable_features);
     info->has_unavailable_features = true;
     info->q_typename = g_strdup(object_class_get_name(oc));
+    info->migration_safe = cc->migration_safe;
+    info->has_migration_safe = true;
 
     entry = g_malloc0(sizeof(*entry));
     entry->value = info;
@@ -2356,6 +2358,7 @@ static void x86_cpu_cpudef_class_init(ObjectClass *oc, void *data)
     X86CPUClass *xcc = X86_CPU_CLASS(oc);
 
     xcc->cpu_def = cpudef;
+    xcc->migration_safe = true;
 }
 
 static void x86_register_cpudef_type(X86CPUDefinition *def)
-- 
2.11.0.259.g40922b1

Re: [Qemu-devel] [PATCH] i386: Return migration-safe field on query-cpu-definitions

[David Hildenbrand]

Am 16.01.2017 um 19:12 schrieb Eduardo Habkost:
> Return the migration-safe field on query-cpu-definitions. All CPU
> models in x86 are migration-safe except "host".
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target/i386/cpu-qom.h | 2 ++
>  target/i386/cpu.c     | 3 +++
>  2 files changed, 5 insertions(+)
>
> diff --git a/target/i386/cpu-qom.h b/target/i386/cpu-qom.h
> index 7c9a07ae65..8cd607e9a2 100644
> --- a/target/i386/cpu-qom.h
> +++ b/target/i386/cpu-qom.h
> @@ -48,6 +48,7 @@ typedef struct X86CPUDefinition X86CPUDefinition;
>   * X86CPUClass:
>   * @cpu_def: CPU model definition
>   * @kvm_required: Whether CPU model requires KVM to be enabled.
> + * @migration_safe: See CpuDefinitionInfo::migration_safe
>   * @parent_realize: The parent class' realize handler.
>   * @parent_reset: The parent class' reset handler.
>   *
> @@ -62,6 +63,7 @@ typedef struct X86CPUClass {
>      X86CPUDefinition *cpu_def;
>
>      bool kvm_required;
> +    bool migration_safe;
>
>      /* Optional description of CPU model.
>       * If unavailable, cpu_def->model_id is used */
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 337636a96a..ec6eaf215c 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -2209,6 +2209,8 @@ static void x86_cpu_definition_entry(gpointer data, gpointer user_data)
>      x86_cpu_class_check_missing_features(cc, &info->unavailable_features);
>      info->has_unavailable_features = true;
>      info->q_typename = g_strdup(object_class_get_name(oc));
> +    info->migration_safe = cc->migration_safe;
> +    info->has_migration_safe = true;
>
>      entry = g_malloc0(sizeof(*entry));
>      entry->value = info;
> @@ -2356,6 +2358,7 @@ static void x86_cpu_cpudef_class_init(ObjectClass *oc, void *data)
>      X86CPUClass *xcc = X86_CPU_CLASS(oc);
>
>      xcc->cpu_def = cpudef;
> +    xcc->migration_safe = true;
>  }
>
>  static void x86_register_cpudef_type(X86CPUDefinition *def)
>

Acked-by: David Hildenbrand <david@redhat.com>

-- 

David