From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Longpeng(Mike)" <longpeng2@huawei.com>
Cc: stefanha@redhat.com, lvivier@redhat.com, eblake@redhat.com,
peter.maydell@linaro.org, groug@kaod.org,
arei.gonglei@huawei.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] qtest: virtio: zeroed last vring_desc after allocate
Date: Tue, 17 Jan 2017 10:55:50 +0000 [thread overview]
Message-ID: <20170117105550.GF4265@stefanha-x1.localdomain> (raw)
In-Reply-To: <1484621964-187372-1-git-send-email-longpeng2@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On Tue, Jan 17, 2017 at 10:59:24AM +0800, Longpeng(Mike) wrote:
> As qvring_indirect_desc_setup() wouldn't initialize last vring_desc,
> so it's filled with dirty data, this might cause virtio backend broken.
>
> For example, the last bit of this vring_desc's flags might be 1, so
> virtqueue_read_next_desc() would report "Desc next is ***".
>
> Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
>
> ---
> Changes since v1:
> - use writel() for @len as it's 32 bits long. [Stefan]
>
> ---
> tests/libqos/virtio.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2017-01-17 10:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 2:59 [Qemu-devel] [PATCH v2] qtest: virtio: zeroed last vring_desc after allocate Longpeng(Mike)
2017-01-17 10:55 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117105550.GF4265@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=arei.gonglei@huawei.com \
--cc=eblake@redhat.com \
--cc=groug@kaod.org \
--cc=longpeng2@huawei.com \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).