qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 2/2] vl: Print warning when a default config file is loaded
Date: Wed, 18 Jan 2017 11:56:24 -0200	[thread overview]
Message-ID: <20170118135624.17368-3-ehabkost@redhat.com> (raw)
In-Reply-To: <20170118135624.17368-1-ehabkost@redhat.com>

In case there were options set in the default config file, print
a warning so users can update their scripts.

If somebody wants to keep the config file as-is, avoid the
warning and use a command-line that will work in future QEMU
versions, they can use:

 $QEMU -nodefconfig -readconfig /etc/qemu/qemu.conf

I was going to add an additional message suggesting it as a
solution, but I thought it could make it more confusing. The
solution can be documented in the QEMU 2.9 ChangeLog.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 vl.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/vl.c b/vl.c
index b563f9b924..e80b6da4bd 100644
--- a/vl.c
+++ b/vl.c
@@ -2999,6 +2999,12 @@ static int qemu_read_default_config_file(void)
         return ret;
     }
 
+    if (ret > 0) {
+        loc_set_none();
+        error_report("Warning: Future QEMU versions won't load %s automatically",
+                     CONFIG_QEMU_CONFDIR "/qemu.conf");
+    }
+
     return 0;
 }
 
-- 
2.11.0.259.g40922b1

  parent reply	other threads:[~2017-01-18 13:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 13:56 [Qemu-devel] [PATCH 0/2] vl: Print warning if a non-empty default config-file is found Eduardo Habkost
2017-01-18 13:56 ` [Qemu-devel] [PATCH 1/2] config: qemu_config_parse() return number of config groups Eduardo Habkost
2017-02-27 17:59   ` Markus Armbruster
2017-02-27 19:05     ` Eduardo Habkost
2017-02-27 19:48       ` Markus Armbruster
2017-01-18 13:56 ` Eduardo Habkost [this message]
2017-01-18 16:04   ` [Qemu-devel] [PATCH 2/2] vl: Print warning when a default config file is loaded Markus Armbruster
2017-01-18 16:24     ` Eduardo Habkost
2017-02-27 18:00       ` Markus Armbruster
2017-02-27 16:13 ` [Qemu-devel] [PATCH 0/2] vl: Print warning if a non-empty default config-file is found Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170118135624.17368-3-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).