From: Stefan Hajnoczi <stefanha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, famz@redhat.com
Subject: Re: [Qemu-devel] [PATCH 10/16] block: explicitly acquire aiocontext in timers that need it
Date: Wed, 18 Jan 2017 15:43:10 +0000 [thread overview]
Message-ID: <20170118154310.GK30347@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170113131731.1246-11-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On Fri, Jan 13, 2017 at 02:17:25PM +0100, Paolo Bonzini wrote:
> diff --git a/block/null.c b/block/null.c
> index b300390..356209a 100644
> --- a/block/null.c
> +++ b/block/null.c
> @@ -141,7 +141,11 @@ static void null_bh_cb(void *opaque)
> static void null_timer_cb(void *opaque)
> {
> NullAIOCB *acb = opaque;
> + AioContext *ctx = bdrv_get_aio_context(acb->common.bs);
> +
> + aio_context_acquire(ctx);
> acb->common.cb(acb->common.opaque, 0);
> + aio_context_release(ctx);
> timer_deinit(&acb->timer);
> qemu_aio_unref(acb);
Is qemu_aio_unref() thread-safe?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-01-18 15:43 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 13:17 [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2 Paolo Bonzini
2017-01-13 13:17 ` [Qemu-devel] [PATCH 01/16] aio: introduce aio_co_schedule and aio_co_wake Paolo Bonzini
2017-01-16 11:09 ` Fam Zheng
2017-01-16 12:19 ` Paolo Bonzini
2017-01-16 12:44 ` Fam Zheng
2017-01-18 14:33 ` Stefan Hajnoczi
2017-01-18 15:40 ` Paolo Bonzini
2017-01-19 16:49 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 02/16] block-backend: allow blk_prw from coroutine context Paolo Bonzini
2017-01-18 14:35 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 03/16] test-thread-pool: use generic AioContext infrastructure Paolo Bonzini
2017-01-18 14:35 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 04/16] io: add methods to set I/O handlers on AioContext Paolo Bonzini
2017-01-16 11:31 ` Fam Zheng
2017-01-16 12:52 ` Daniel P. Berrange
2017-01-16 12:54 ` Daniel P. Berrange
2017-01-18 14:47 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 05/16] io: make qio_channel_yield aware of AioContexts Paolo Bonzini
2017-01-16 11:38 ` Fam Zheng
2017-01-16 12:24 ` Paolo Bonzini
2017-01-16 12:47 ` Fam Zheng
2017-01-16 12:59 ` Daniel P. Berrange
2017-01-16 12:55 ` Daniel P. Berrange
2017-01-18 14:48 ` Stefan Hajnoczi
2017-01-16 12:58 ` Daniel P. Berrange
2017-01-16 14:18 ` Paolo Bonzini
2017-01-18 14:58 ` Stefan Hajnoczi
2017-01-18 16:43 ` Paolo Bonzini
2017-01-18 17:22 ` Eric Blake
2017-01-13 13:17 ` [Qemu-devel] [PATCH 06/16] nbd: do not block on partial reply header reads Paolo Bonzini
2017-01-16 12:52 ` Fam Zheng
2017-01-16 13:31 ` Paolo Bonzini
2017-01-18 15:24 ` Stefan Hajnoczi
2017-01-18 16:43 ` Paolo Bonzini
2017-01-13 13:17 ` [Qemu-devel] [PATCH 07/16] coroutine-lock: reschedule coroutine on the AioContext it was running on Paolo Bonzini
2017-01-18 15:26 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 08/16] qed: introduce qed_aio_start_io and qed_aio_next_io_cb Paolo Bonzini
2017-01-18 15:27 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 09/16] aio: push aio_context_acquire/release down to dispatching Paolo Bonzini
2017-01-18 15:29 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 10/16] block: explicitly acquire aiocontext in timers that need it Paolo Bonzini
2017-01-16 13:07 ` Fam Zheng
2017-01-16 13:32 ` Paolo Bonzini
2017-01-16 13:50 ` Fam Zheng
2017-01-18 15:43 ` Stefan Hajnoczi [this message]
2017-01-18 16:44 ` Paolo Bonzini
2017-01-19 16:59 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 11/16] block: explicitly acquire aiocontext in callbacks " Paolo Bonzini
2017-01-16 13:36 ` Fam Zheng
2017-01-16 14:49 ` Paolo Bonzini
2017-01-18 15:49 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 12/16] block: explicitly acquire aiocontext in bottom halves " Paolo Bonzini
2017-01-18 15:54 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 13/16] block: explicitly acquire aiocontext in aio callbacks " Paolo Bonzini
2017-01-18 15:58 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 14/16] aio-posix: partially inline aio_dispatch into aio_poll Paolo Bonzini
2017-01-18 15:59 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 15/16] async: remove unnecessary inc/dec pairs Paolo Bonzini
2017-01-18 16:00 ` Stefan Hajnoczi
2017-01-13 13:17 ` [Qemu-devel] [PATCH 16/16] block: document fields protected by AioContext lock Paolo Bonzini
2017-01-18 16:01 ` Stefan Hajnoczi
2017-01-16 16:26 ` [Qemu-devel] [PATCH 00/16] aio_context_acquire/release pushdown, part 2 Fam Zheng
2017-01-18 16:02 ` Stefan Hajnoczi
2017-01-18 16:07 ` Paolo Bonzini
2017-01-18 16:03 ` Stefan Hajnoczi
2017-01-18 16:31 ` Paolo Bonzini
2017-01-19 17:01 ` Stefan Hajnoczi
2017-01-20 16:39 ` Paolo Bonzini
2017-01-23 10:36 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118154310.GK30347@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).