qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, John Snow <jsnow@redhat.com>,
	"open list:Floppy" <qemu-block@nongnu.org>
Subject: [Qemu-devel] [PATCH v2 4/6] fdc-test: Avoid deprecated 'change' command
Date: Wed, 18 Jan 2017 10:16:51 -0600	[thread overview]
Message-ID: <20170118161653.19296-5-eblake@redhat.com> (raw)
In-Reply-To: <20170118161653.19296-1-eblake@redhat.com>

Use the preferred blockdev-change-medium command instead.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
 tests/fdc-test.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/fdc-test.c b/tests/fdc-test.c
index 738c6b4..f5ff68d 100644
--- a/tests/fdc-test.c
+++ b/tests/fdc-test.c
@@ -298,8 +298,9 @@ static void test_media_insert(void)

     /* Insert media in drive. DSKCHK should not be reset until a step pulse
      * is sent. */
-    qmp_discard_response("{'execute':'change', 'arguments':{"
-                         " 'device':'floppy0', 'target': %s, 'arg': 'raw' }}",
+    qmp_discard_response("{'execute':'blockdev-change-medium', 'arguments':{"
+                         " 'device':'floppy0', 'filename': %s, "
+                         "'format': 'raw' }}",
                          test_image);

     dir = inb(FLOPPY_BASE + reg_dir);
-- 
2.9.3

  parent reply	other threads:[~2017-01-18 16:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 16:16 [Qemu-devel] [PATCH v2 0/6] qapi-related cleanups Eric Blake
2017-01-18 16:16 ` [Qemu-devel] [PATCH v2 1/6] pci: Use struct instead of QDict to pass back parameters Eric Blake
2017-01-18 16:57   ` Michael S. Tsirkin
2017-01-19  9:08   ` Marc-André Lureau
2017-01-19  9:23   ` Markus Armbruster
2017-01-18 16:16 ` [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts Eric Blake
2017-01-19  9:08   ` Marc-André Lureau
2017-01-19  9:25   ` Markus Armbruster
2017-01-19 14:38     ` Eric Blake
2017-04-04 22:41       ` Eric Blake
2017-04-05  8:18         ` Richard W.M. Jones
2017-04-05  8:21           ` Julia Lawall
2017-04-05  8:24             ` Richard W.M. Jones
2017-04-05  8:38               ` Julia Lawall
2017-04-05  9:01                 ` Richard W.M. Jones
2017-04-05 11:54                   ` Paolo Bonzini
2017-04-05 15:16                     ` Eric Blake
2017-01-19 17:36   ` Stefan Hajnoczi
2017-01-18 16:16 ` [Qemu-devel] [PATCH v2 3/6] qlist: Add convenience helpers for wrapped appends Eric Blake
2017-01-19  9:08   ` Marc-André Lureau
2017-01-18 16:16 ` Eric Blake [this message]
2017-01-19  9:30   ` [Qemu-devel] [PATCH v2 4/6] fdc-test: Avoid deprecated 'change' command Markus Armbruster
2017-01-19 14:39     ` Eric Blake
2017-04-05  2:10       ` Eric Blake
2017-04-11  8:49         ` Markus Armbruster
2017-04-11  8:58           ` Kevin Wolf
2017-01-18 16:16 ` [Qemu-devel] [PATCH v2 5/6] test-qga: Actually test 0xff sync bytes Eric Blake
2017-01-19  9:08   ` Marc-André Lureau
2017-01-19  9:45   ` Markus Armbruster
2017-01-18 16:16 ` [Qemu-devel] [PATCH v2 6/6] qapi: Promote blockdev-change-medium arguments to QAPI type Eric Blake
2017-01-19  9:07   ` Marc-André Lureau
2017-01-19  9:48   ` Markus Armbruster
2017-01-19 14:42     ` Eric Blake
2017-01-20  7:15       ` Markus Armbruster
2017-01-20 14:38         ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170118161653.19296-5-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).