* [Qemu-devel] [qemu PATCH] pc.h: move x-mach-use-reliable-get-clock compat entry to PC_COMPAT_2_8
@ 2017-01-18 17:53 Marcelo Tosatti
2017-01-20 11:04 ` Dr. David Alan Gilbert
2017-01-20 12:23 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2017-01-18 17:53 UTC (permalink / raw)
To: qemu-devel; +Cc: Dr. David Alan Gilbert, Paolo Bonzini
As noticed by David Gilbert, commit 6053a86 'kvmclock: reduce kvmclock
differences on migration' added 'x-mach-use-reliable-get-clock' and a
compatibility entry that turns it off; however it got merged after 2.8.0
was released but the entry has gone into PC_COMPAT_2_7 where it should
have gone into PC_COMPAT_2_8.
Fix it by moving the entry to PC_COMPAT_2_8.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index b22e699..738bfd6 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -375,14 +375,15 @@ int e820_get_num_entries(void);
bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
#define PC_COMPAT_2_8 \
-
-#define PC_COMPAT_2_7 \
- HW_COMPAT_2_7 \
+ HW_COMPAT_2_8 \
{\
.driver = "kvmclock",\
.property = "x-mach-use-reliable-get-clock",\
.value = "off",\
},\
+
+#define PC_COMPAT_2_7 \
+ HW_COMPAT_2_7 \
{\
.driver = TYPE_X86_CPU,\
.property = "l3-cache",\
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [qemu PATCH] pc.h: move x-mach-use-reliable-get-clock compat entry to PC_COMPAT_2_8
2017-01-18 17:53 [Qemu-devel] [qemu PATCH] pc.h: move x-mach-use-reliable-get-clock compat entry to PC_COMPAT_2_8 Marcelo Tosatti
@ 2017-01-20 11:04 ` Dr. David Alan Gilbert
2017-01-20 12:23 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2017-01-20 11:04 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: qemu-devel, Paolo Bonzini
* Marcelo Tosatti (mtosatti@redhat.com) wrote:
>
> As noticed by David Gilbert, commit 6053a86 'kvmclock: reduce kvmclock
> differences on migration' added 'x-mach-use-reliable-get-clock' and a
> compatibility entry that turns it off; however it got merged after 2.8.0
> was released but the entry has gone into PC_COMPAT_2_7 where it should
> have gone into PC_COMPAT_2_8.
>
> Fix it by moving the entry to PC_COMPAT_2_8.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index b22e699..738bfd6 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -375,14 +375,15 @@ int e820_get_num_entries(void);
> bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
>
> #define PC_COMPAT_2_8 \
> -
> -#define PC_COMPAT_2_7 \
> - HW_COMPAT_2_7 \
> + HW_COMPAT_2_8 \
> {\
> .driver = "kvmclock",\
> .property = "x-mach-use-reliable-get-clock",\
> .value = "off",\
> },\
> +
> +#define PC_COMPAT_2_7 \
> + HW_COMPAT_2_7 \
> {\
> .driver = TYPE_X86_CPU,\
> .property = "l3-cache",\
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [qemu PATCH] pc.h: move x-mach-use-reliable-get-clock compat entry to PC_COMPAT_2_8
2017-01-18 17:53 [Qemu-devel] [qemu PATCH] pc.h: move x-mach-use-reliable-get-clock compat entry to PC_COMPAT_2_8 Marcelo Tosatti
2017-01-20 11:04 ` Dr. David Alan Gilbert
@ 2017-01-20 12:23 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2017-01-20 12:23 UTC (permalink / raw)
To: Marcelo Tosatti, qemu-devel; +Cc: Dr. David Alan Gilbert
On 18/01/2017 18:53, Marcelo Tosatti wrote:
>
> As noticed by David Gilbert, commit 6053a86 'kvmclock: reduce kvmclock
> differences on migration' added 'x-mach-use-reliable-get-clock' and a
> compatibility entry that turns it off; however it got merged after 2.8.0
> was released but the entry has gone into PC_COMPAT_2_7 where it should
> have gone into PC_COMPAT_2_8.
>
> Fix it by moving the entry to PC_COMPAT_2_8.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index b22e699..738bfd6 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -375,14 +375,15 @@ int e820_get_num_entries(void);
> bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
>
> #define PC_COMPAT_2_8 \
> -
> -#define PC_COMPAT_2_7 \
> - HW_COMPAT_2_7 \
> + HW_COMPAT_2_8 \
> {\
> .driver = "kvmclock",\
> .property = "x-mach-use-reliable-get-clock",\
> .value = "off",\
> },\
> +
> +#define PC_COMPAT_2_7 \
> + HW_COMPAT_2_7 \
> {\
> .driver = TYPE_X86_CPU,\
> .property = "l3-cache",\
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-20 12:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-18 17:53 [Qemu-devel] [qemu PATCH] pc.h: move x-mach-use-reliable-get-clock compat entry to PC_COMPAT_2_8 Marcelo Tosatti
2017-01-20 11:04 ` Dr. David Alan Gilbert
2017-01-20 12:23 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).