From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTxaX-0002HS-CX for qemu-devel@nongnu.org; Wed, 18 Jan 2017 16:16:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTxaU-0005Tw-4q for qemu-devel@nongnu.org; Wed, 18 Jan 2017 16:16:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36642) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTxaT-0005TZ-V0 for qemu-devel@nongnu.org; Wed, 18 Jan 2017 16:16:10 -0500 Date: Wed, 18 Jan 2017 23:16:07 +0200 From: "Michael S. Tsirkin" Message-ID: <20170118231450-mutt-send-email-mst@kernel.org> References: <1484772931-16272-1-git-send-email-mst@redhat.com> <1484772931-16272-3-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 2/4] compiler: drop ; after BUILD_BUG_ON List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Paolo Bonzini , Eric Blake , Richard Henderson On Wed, Jan 18, 2017 at 09:04:03PM +0000, Peter Maydell wrote: > On 18 January 2017 at 20:55, Michael S. Tsirkin wrote: > > All users include the trailing ;, let's require that > > so that uses such as if (a) QEMU_BUILD_BUG_ON(); do not > > produce unexpected results. > > When would it ever make sense for a build-time > assert to be the only thing inside a runtime > conditional anyway? > > thanks > -- PMM What do I know? Do you want to keep the trailing ; in there? I can drop this patch. -- MST