[Qemu-devel] qemu-img: complains about missing iscsi option group

[Qemu-devel] qemu-img: complains about missing iscsi option group

[Peter Lieven]

Hi all,


since commit f57b4b5 (blockdev: prepare iSCSI block driver for dynamic loading)

qemu-img complains about a missing option group several times.


~/git/qemu$ ./qemu-img info iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-00lieven-data/0
qemu-img: There is no option group 'iscsi'
qemu-img: There is no option group 'iscsi'
qemu-img: There is no option group 'iscsi'
qemu-img: There is no option group 'iscsi'
image: iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-00lieven-data/0
file format: raw
virtual size: 25G (26848788480 bytes)
disk size: unavailable
cluster_size: 15728640

I don't know whats the proper way to fix this?


Thanks,

Peter

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

[Daniel P. Berrange]

On Thu, Jan 19, 2017 at 05:30:20PM +0100, Peter Lieven wrote:
> Hi all,
> 
> 
> since commit f57b4b5 (blockdev: prepare iSCSI block driver for dynamic loading)
> 
> qemu-img complains about a missing option group several times.
> 
> 
> ~/git/qemu$ ./qemu-img info iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-00lieven-data/0
> qemu-img: There is no option group 'iscsi'
> qemu-img: There is no option group 'iscsi'
> qemu-img: There is no option group 'iscsi'
> qemu-img: There is no option group 'iscsi'
> image: iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-00lieven-data/0
> file format: raw
> virtual size: 25G (26848788480 bytes)
> disk size: unavailable
> cluster_size: 15728640
> 
> I don't know whats the proper way to fix this?

Move the iscsi option registration out of vl.c and back into a shared file
in block/ such that all programs see the options, not just the emulators.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

[Peter Lieven]

Am 19.01.2017 um 17:38 schrieb Daniel P. Berrange:
> On Thu, Jan 19, 2017 at 05:30:20PM +0100, Peter Lieven wrote:
>> Hi all,
>>
>>
>> since commit f57b4b5 (blockdev: prepare iSCSI block driver for dynamic loading)
>>
>> qemu-img complains about a missing option group several times.
>>
>>
>> ~/git/qemu$ ./qemu-img info iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-00lieven-data/0
>> qemu-img: There is no option group 'iscsi'
>> qemu-img: There is no option group 'iscsi'
>> qemu-img: There is no option group 'iscsi'
>> qemu-img: There is no option group 'iscsi'
>> image: iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-00lieven-data/0
>> file format: raw
>> virtual size: 25G (26848788480 bytes)
>> disk size: unavailable
>> cluster_size: 15728640
>>
>> I don't know whats the proper way to fix this?
> Move the iscsi option registration out of vl.c and back into a shared file
> in block/ such that all programs see the options, not just the emulators.

Any preference which file? It seems no other block driver registers options.

Thanks,
Peter

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

[Daniel P. Berrange]

On Thu, Jan 19, 2017 at 05:57:45PM +0100, Peter Lieven wrote:
> Am 19.01.2017 um 17:38 schrieb Daniel P. Berrange:
> > On Thu, Jan 19, 2017 at 05:30:20PM +0100, Peter Lieven wrote:
> > > Hi all,
> > > 
> > > 
> > > since commit f57b4b5 (blockdev: prepare iSCSI block driver for dynamic loading)
> > > 
> > > qemu-img complains about a missing option group several times.
> > > 
> > > 
> > > ~/git/qemu$ ./qemu-img info iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-00lieven-data/0
> > > qemu-img: There is no option group 'iscsi'
> > > qemu-img: There is no option group 'iscsi'
> > > qemu-img: There is no option group 'iscsi'
> > > qemu-img: There is no option group 'iscsi'
> > > image: iscsi://172.21.200.56:3260/iqn.2001-05.com.equallogic:0-8a0906-69d384e0a-aa3004e55e15878d-00lieven-data/0
> > > file format: raw
> > > virtual size: 25G (26848788480 bytes)
> > > disk size: unavailable
> > > cluster_size: 15728640
> > > 
> > > I don't know whats the proper way to fix this?
> > Move the iscsi option registration out of vl.c and back into a shared file
> > in block/ such that all programs see the options, not just the emulators.
> 
> Any preference which file? It seems no other block driver registers options.

ISCSI is somewhat bizarre in that it has a separate global -iscsi arg
instead of just accepting all args via the -drive spec like every other
block driver does, so there's no precedent to follow.

So suggest we just need a block/iscsi-global.c to deal with this.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

[Paolo Bonzini]

On 19/01/2017 18:03, Daniel P. Berrange wrote:
>>> Move the iscsi option registration out of vl.c and back into a shared file
>>> in block/ such that all programs see the options, not just the emulators.
>> Any preference which file? It seems no other block driver registers options.
> ISCSI is somewhat bizarre in that it has a separate global -iscsi arg
> instead of just accepting all args via the -drive spec like every other
> block driver does, so there's no precedent to follow.
> 
> So suggest we just need a block/iscsi-global.c to deal with this.

Why not block/iscsi.c itself?

Paolo

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

[Peter Lieven]

Am 24.01.2017 um 12:24 schrieb Paolo Bonzini:
>
> On 19/01/2017 18:03, Daniel P. Berrange wrote:
>>>> Move the iscsi option registration out of vl.c and back into a shared file
>>>> in block/ such that all programs see the options, not just the emulators.
>>> Any preference which file? It seems no other block driver registers options.
>> ISCSI is somewhat bizarre in that it has a separate global -iscsi arg
>> instead of just accepting all args via the -drive spec like every other
>> block driver does, so there's no precedent to follow.
>>
>> So suggest we just need a block/iscsi-global.c to deal with this.
> Why not block/iscsi.c itself?

As far as I understand block/iscsi is now compiled as a shared object.

Peter

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

[Daniel P. Berrange]

On Tue, Jan 24, 2017 at 12:24:02PM +0100, Paolo Bonzini wrote:
> 
> 
> On 19/01/2017 18:03, Daniel P. Berrange wrote:
> >>> Move the iscsi option registration out of vl.c and back into a shared file
> >>> in block/ such that all programs see the options, not just the emulators.
> >> Any preference which file? It seems no other block driver registers options.
> > ISCSI is somewhat bizarre in that it has a separate global -iscsi arg
> > instead of just accepting all args via the -drive spec like every other
> > block driver does, so there's no precedent to follow.
> > 
> > So suggest we just need a block/iscsi-global.c to deal with this.
> 
> Why not block/iscsi.c itself?

block/iscsi.c is a module, so not linked to qemu emulators by default.
You could still have the iscsi options in that file if you used a
conditional and built the same file twice with different content,
but it seems easier to just use a separate file


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

[Paolo Bonzini]

On 24/01/2017 12:25, Peter Lieven wrote:
> Am 24.01.2017 um 12:24 schrieb Paolo Bonzini:
>>
>> On 19/01/2017 18:03, Daniel P. Berrange wrote:
>>>>> Move the iscsi option registration out of vl.c and back into a
>>>>> shared file
>>>>> in block/ such that all programs see the options, not just the
>>>>> emulators.
>>>> Any preference which file? It seems no other block driver registers
>>>> options.
>>> ISCSI is somewhat bizarre in that it has a separate global -iscsi arg
>>> instead of just accepting all args via the -drive spec like every other
>>> block driver does, so there's no precedent to follow.
>>>
>>> So suggest we just need a block/iscsi-global.c to deal with this.
>> Why not block/iscsi.c itself?
> 
> As far as I understand block/iscsi is now compiled as a shared object.

Uh, right. :(

Paolo

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

[Peter Lieven]

Am 24.01.2017 um 12:29 schrieb Paolo Bonzini:
>
> On 24/01/2017 12:25, Peter Lieven wrote:
>> Am 24.01.2017 um 12:24 schrieb Paolo Bonzini:
>>> On 19/01/2017 18:03, Daniel P. Berrange wrote:
>>>>>> Move the iscsi option registration out of vl.c and back into a
>>>>>> shared file
>>>>>> in block/ such that all programs see the options, not just the
>>>>>> emulators.
>>>>> Any preference which file? It seems no other block driver registers
>>>>> options.
>>>> ISCSI is somewhat bizarre in that it has a separate global -iscsi arg
>>>> instead of just accepting all args via the -drive spec like every other
>>>> block driver does, so there's no precedent to follow.
>>>>
>>>> So suggest we just need a block/iscsi-global.c to deal with this.
>>> Why not block/iscsi.c itself?
>> As far as I understand block/iscsi is now compiled as a shared object.
> Uh, right. :(

Okay, so a new file iscsi-static.c ?

Peter

Re: [Qemu-devel] qemu-img: complains about missing iscsi option group

[Paolo Bonzini]

On 24/01/2017 12:40, Peter Lieven wrote:
> Am 24.01.2017 um 12:29 schrieb Paolo Bonzini:
>>
>> On 24/01/2017 12:25, Peter Lieven wrote:
>>> Am 24.01.2017 um 12:24 schrieb Paolo Bonzini:
>>>> On 19/01/2017 18:03, Daniel P. Berrange wrote:
>>>>>>> Move the iscsi option registration out of vl.c and back into a
>>>>>>> shared file
>>>>>>> in block/ such that all programs see the options, not just the
>>>>>>> emulators.
>>>>>> Any preference which file? It seems no other block driver registers
>>>>>> options.
>>>>> ISCSI is somewhat bizarre in that it has a separate global -iscsi arg
>>>>> instead of just accepting all args via the -drive spec like every
>>>>> other
>>>>> block driver does, so there's no precedent to follow.
>>>>>
>>>>> So suggest we just need a block/iscsi-global.c to deal with this.
>>>> Why not block/iscsi.c itself?
>>> As far as I understand block/iscsi is now compiled as a shared object.
>> Uh, right. :(
> 
> Okay, so a new file iscsi-static.c ?

Yes, something like that.  Or block/iscsi-opts.c too.

Paolo