From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
rjones@redhat.com, Max Reitz <mreitz@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
eblake@redhat.com
Subject: [Qemu-devel] [PATCH v11 06/16] iotests: 055: Don't attach the drive to vm for drive-backup
Date: Fri, 20 Jan 2017 15:23:00 +0800 [thread overview]
Message-ID: <20170120072310.8009-7-famz@redhat.com> (raw)
In-Reply-To: <20170120072310.8009-1-famz@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/qemu-iotests/055 | 32 ++++++++++++++++++--------------
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/055
index 1d3fd04..20a7596 100755
--- a/tests/qemu-iotests/055
+++ b/tests/qemu-iotests/055
@@ -455,17 +455,18 @@ class TestDriveCompression(iotests.QMPTestCase):
except OSError:
pass
- def do_prepare_drives(self, fmt, args):
+ def do_prepare_drives(self, fmt, args, attach):
self.vm = iotests.VM().add_drive(test_img)
qemu_img('create', '-f', fmt, blockdev_target_img,
str(TestDriveCompression.image_len), *args)
- self.vm.add_drive(blockdev_target_img, format=fmt)
+ if attach:
+ self.vm.add_drive(blockdev_target_img, format=fmt)
self.vm.launch()
- def do_test_compress_complete(self, cmd, format, **args):
- self.do_prepare_drives(format['type'], format['args'])
+ def do_test_compress_complete(self, cmd, format, attach, **args):
+ self.do_prepare_drives(format['type'], format['args'], attach)
self.assert_no_active_block_jobs()
@@ -481,15 +482,16 @@ class TestDriveCompression(iotests.QMPTestCase):
def test_complete_compress_drive_backup(self):
for format in TestDriveCompression.fmt_supports_compression:
- self.do_test_compress_complete('drive-backup', format,
+ self.do_test_compress_complete('drive-backup', format, attach=False,
target=blockdev_target_img, mode='existing')
def test_complete_compress_blockdev_backup(self):
for format in TestDriveCompression.fmt_supports_compression:
- self.do_test_compress_complete('blockdev-backup', format, target='drive1')
+ self.do_test_compress_complete('blockdev-backup', format,
+ attach=True, target='drive1')
- def do_test_compress_cancel(self, cmd, format, **args):
- self.do_prepare_drives(format['type'], format['args'])
+ def do_test_compress_cancel(self, cmd, format, attach, **args):
+ self.do_prepare_drives(format['type'], format['args'], attach)
self.assert_no_active_block_jobs()
@@ -503,15 +505,16 @@ class TestDriveCompression(iotests.QMPTestCase):
def test_compress_cancel_drive_backup(self):
for format in TestDriveCompression.fmt_supports_compression:
- self.do_test_compress_cancel('drive-backup', format,
+ self.do_test_compress_cancel('drive-backup', format, attach=False,
target=blockdev_target_img, mode='existing')
def test_compress_cancel_blockdev_backup(self):
for format in TestDriveCompression.fmt_supports_compression:
- self.do_test_compress_cancel('blockdev-backup', format, target='drive1')
+ self.do_test_compress_cancel('blockdev-backup', format, attach=True,
+ target='drive1')
- def do_test_compress_pause(self, cmd, format, **args):
- self.do_prepare_drives(format['type'], format['args'])
+ def do_test_compress_pause(self, cmd, format, attach, **args):
+ self.do_prepare_drives(format['type'], format['args'], attach)
self.assert_no_active_block_jobs()
@@ -543,12 +546,13 @@ class TestDriveCompression(iotests.QMPTestCase):
def test_compress_pause_drive_backup(self):
for format in TestDriveCompression.fmt_supports_compression:
- self.do_test_compress_pause('drive-backup', format,
+ self.do_test_compress_pause('drive-backup', format, attach=False,
target=blockdev_target_img, mode='existing')
def test_compress_pause_blockdev_backup(self):
for format in TestDriveCompression.fmt_supports_compression:
- self.do_test_compress_pause('blockdev-backup', format, target='drive1')
+ self.do_test_compress_pause('blockdev-backup', format, attach=True,
+ target='drive1')
if __name__ == '__main__':
iotests.main(supported_fmts=['raw', 'qcow2'])
--
2.9.3
next prev parent reply other threads:[~2017-01-20 7:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 7:22 [Qemu-devel] [PATCH v11 00/16] block: Image locking series Fam Zheng
2017-01-20 7:22 ` [Qemu-devel] [PATCH v11 01/16] osdep: Add qemu_lock_fd and qemu_unlock_fd Fam Zheng
2017-01-20 7:22 ` [Qemu-devel] [PATCH v11 02/16] block: Define BDRV_O_SHARE_RW Fam Zheng
2017-01-20 7:22 ` [Qemu-devel] [PATCH v11 03/16] qemu-io: Set "share-rw" flag together with read-only Fam Zheng
2017-01-20 7:22 ` [Qemu-devel] [PATCH v11 04/16] qemu-img: Set "share-rw" flag in read-only commands Fam Zheng
2017-01-20 7:22 ` [Qemu-devel] [PATCH v11 05/16] block: Set "share-rw" flag in drive-backup when sync=none Fam Zheng
2017-01-20 7:23 ` Fam Zheng [this message]
2017-01-20 7:23 ` [Qemu-devel] [PATCH v11 07/16] iotests: 030: Read-only open image for getting map Fam Zheng
2017-01-20 7:23 ` [Qemu-devel] [PATCH v11 08/16] iotests: 087: Don't attach test image twice Fam Zheng
2017-01-20 7:23 ` [Qemu-devel] [PATCH v11 09/16] iotests: 085: Avoid image locking conflict Fam Zheng
2017-01-20 7:23 ` [Qemu-devel] [PATCH v11 10/16] iotests: 091: Quit QEMU before checking image Fam Zheng
2017-01-20 7:23 ` [Qemu-devel] [PATCH v11 11/16] iotests: 172: Use separate images for multiple devices Fam Zheng
2017-01-20 7:23 ` [Qemu-devel] [PATCH v11 12/16] tests: Use null-co:// instead of /dev/null as the dummy image Fam Zheng
2017-01-20 7:23 ` [Qemu-devel] [PATCH v11 13/16] tests: Disable image lock in test-replication Fam Zheng
2017-01-20 7:23 ` [Qemu-devel] [PATCH v11 14/16] file-posix: Implement image locking Fam Zheng
2017-01-20 7:23 ` [Qemu-devel] [PATCH v11 15/16] qcow2: Force "no other writer" lock on bs->file Fam Zheng
2017-01-20 7:23 ` [Qemu-devel] [PATCH v11 16/16] tests: Add test-image-lock Fam Zheng
2017-01-20 14:59 ` [Qemu-devel] [PATCH v11 00/16] block: Image locking series no-reply
2017-01-20 16:46 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120072310.8009-7-famz@redhat.com \
--to=famz@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).