From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, famz@redhat.com
Subject: [Qemu-devel] [PATCH 02/17] block-backend: allow blk_prw from coroutine context
Date: Fri, 20 Jan 2017 17:43:07 +0100 [thread overview]
Message-ID: <20170120164322.21851-3-pbonzini@redhat.com> (raw)
In-Reply-To: <20170120164322.21851-1-pbonzini@redhat.com>
qcow2_create2 calls this. Do not run a nested event loop, as that
breaks when aio_co_wake tries to queue the coroutine on the co_queue_wakeup
list of the currently running one.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/block-backend.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index efbf398..1177598 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -880,7 +880,6 @@ static int blk_prw(BlockBackend *blk, int64_t offset, uint8_t *buf,
{
QEMUIOVector qiov;
struct iovec iov;
- Coroutine *co;
BlkRwCo rwco;
iov = (struct iovec) {
@@ -897,9 +896,14 @@ static int blk_prw(BlockBackend *blk, int64_t offset, uint8_t *buf,
.ret = NOT_DONE,
};
- co = qemu_coroutine_create(co_entry, &rwco);
- qemu_coroutine_enter(co);
- BDRV_POLL_WHILE(blk_bs(blk), rwco.ret == NOT_DONE);
+ if (qemu_in_coroutine()) {
+ /* Fast-path if already in coroutine context */
+ co_entry(&rwco);
+ } else {
+ Coroutine *co = qemu_coroutine_create(co_entry, &rwco);
+ qemu_coroutine_enter(co);
+ BDRV_POLL_WHILE(blk_bs(blk), rwco.ret == NOT_DONE);
+ }
return rwco.ret;
}
--
2.9.3
next prev parent reply other threads:[~2017-01-20 16:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 16:43 [Qemu-devel] [PATCH 00/17] aio_context_acquire/release pushdown, part 2 Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 01/17] aio: introduce aio_co_schedule and aio_co_wake Paolo Bonzini
2017-01-30 15:18 ` Stefan Hajnoczi
2017-01-30 20:15 ` Paolo Bonzini
2017-01-20 16:43 ` Paolo Bonzini [this message]
2017-01-20 16:43 ` [Qemu-devel] [PATCH 03/17] test-thread-pool: use generic AioContext infrastructure Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 04/17] block: move AioContext and QEMUTimer to libqemuutil Paolo Bonzini
2017-01-24 9:34 ` Daniel P. Berrange
2017-01-30 15:24 ` Stefan Hajnoczi
2017-01-20 16:43 ` [Qemu-devel] [PATCH 05/17] io: add methods to set I/O handlers on AioContext Paolo Bonzini
2017-01-24 9:35 ` Daniel P. Berrange
2017-01-30 15:32 ` Stefan Hajnoczi
2017-01-20 16:43 ` [Qemu-devel] [PATCH 06/17] io: make qio_channel_yield aware of AioContexts Paolo Bonzini
2017-01-24 9:36 ` Daniel P. Berrange
2017-01-24 9:38 ` Paolo Bonzini
2017-01-24 9:40 ` Daniel P. Berrange
2017-01-30 15:37 ` Stefan Hajnoczi
2017-01-20 16:43 ` [Qemu-devel] [PATCH 07/17] nbd: convert to use qio_channel_yield Paolo Bonzini
2017-01-30 15:50 ` Stefan Hajnoczi
2017-01-30 21:18 ` Paolo Bonzini
2017-01-31 13:50 ` Stefan Hajnoczi
2017-01-31 14:29 ` Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 08/17] coroutine-lock: reschedule coroutine on the AioContext it was running on Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 09/17] qed: introduce qed_aio_start_io and qed_aio_next_io_cb Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 10/17] aio: push aio_context_acquire/release down to dispatching Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 11/17] block: explicitly acquire aiocontext in timers that need it Paolo Bonzini
2017-01-30 16:01 ` Stefan Hajnoczi
2017-01-20 16:43 ` [Qemu-devel] [PATCH 12/17] block: explicitly acquire aiocontext in callbacks " Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 13/17] block: explicitly acquire aiocontext in bottom halves " Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 14/17] block: explicitly acquire aiocontext in aio callbacks " Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 15/17] aio-posix: partially inline aio_dispatch into aio_poll Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 16/17] async: remove unnecessary inc/dec pairs Paolo Bonzini
2017-01-20 16:43 ` [Qemu-devel] [PATCH 17/17] block: document fields protected by AioContext lock Paolo Bonzini
2017-01-24 9:38 ` [Qemu-devel] [PATCH 00/17] aio_context_acquire/release pushdown, part 2 Daniel P. Berrange
2017-01-29 20:48 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120164322.21851-3-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).