qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Gabriel L. Somlo" <somlo@cmu.edu>
To: qemu-devel@nongnu.org
Cc: phil@philjordan.eu, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/2] hw/usb/dev-hid: Make usb-tablet work with OS X/macOS guests
Date: Fri, 20 Jan 2017 20:49:01 -0500	[thread overview]
Message-ID: <20170121014901.GA21645@foober.ini.cmu.edu> (raw)
In-Reply-To: <1484915417-10499-1-git-send-email-phil@philjordan.eu>

On Fri, Jan 20, 2017 at 13:30:15 +0100, phil@philjordan.eu wrote:
> This series makes the Qemu usb-tablet work correctly with OS X/macOS guests without the need for a special guest driver.
> 
>  * The usb-tablet should not have a boot protocol of 2. Other OSes seem to ignore this, but the IOHIDFamily driver stack chokes on it for anything but conventional (relative motion) mice.
>  * A "mac_compat" boolean option is added to the usb-tablet, which changes its report descriptor to specify a usage of 0x02 (mouse) instead of 0x01 (pointer). This is required for correct operation in the Mac HID driver stack.

works like a charm on Sierra (10.12.1). Also tried it with
Fedora-Workstation-Live-x86_64-25-1.3.iso, where it behaves
identically with or without the mac_compat option. All tests
used qemu in SDL/X11-client mode.

Tested-by: Gabriel Somlo <somlo@cmu.edu>

Thanks,
--Gabriel

> 
> Changelog
> =========
> 
> v1 -> v2:
>  * v1 Thread was "[PATCH] hw/usb/dev-hid: add a Mac guest compatibility option to usb-tablet"
>  * Always apply the boot protocol (bInterfaceProtocol) change to usb-tablet, not just when the Mac compatibility option is active. The original value of 0x02 was determined to be incorrect according to the spec anyway.
>  * As the boot protocol change is permanent, separate interface and device descriptor constants for the Mac/non-Mac variants of the tablet are no longer required, and have been removed.
> 
> Phil Dennis-Jordan (2):
>   hw/usb/dev-hid: set bInterfaceProtocol to 0x00 for usb-tablet
>   hw/usb/dev-hid: add a usb-tablet Mac guest compatibility option
> 
>  hw/usb/dev-hid.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

  parent reply	other threads:[~2017-01-21  1:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-20 12:30 [Qemu-devel] [PATCH v2 0/2] hw/usb/dev-hid: Make usb-tablet work with OS X/macOS guests Phil Dennis-Jordan
2017-01-20 12:30 ` [Qemu-devel] [PATCH v2 1/2] hw/usb/dev-hid: set bInterfaceProtocol to 0x00 for usb-tablet Phil Dennis-Jordan
2017-01-20 12:30 ` [Qemu-devel] [PATCH v2 2/2] hw/usb/dev-hid: add a usb-tablet Mac guest compatibility option Phil Dennis-Jordan
2017-01-21  1:49 ` Gabriel L. Somlo [this message]
2017-01-23 12:31   ` [Qemu-devel] [PATCH v2 0/2] hw/usb/dev-hid: Make usb-tablet work with OS X/macOS guests Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170121014901.GA21645@foober.ini.cmu.edu \
    --to=somlo@cmu.edu \
    --cc=kraxel@redhat.com \
    --cc=phil@philjordan.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).