From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Change name of live migration thread
Date: Mon, 23 Jan 2017 09:17:26 +0000 [thread overview]
Message-ID: <20170123091725.GB2098@work-vm> (raw)
In-Reply-To: <1485069471-3680-1-git-send-email-pagupta@redhat.com>
* Pankaj Gupta (pagupta@redhat.com) wrote:
> Change the name of live migration thread from 'migration'
> to 'qemu_vm_migration' to identify it clearly. 'migration'
> is a generic word and kernel also has tasks for process
> migration with the name 'migration/cpu#'.
>
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index f498ab8..6ebd606 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1969,7 +1969,7 @@ void migrate_fd_connect(MigrationState *s)
> }
>
> migrate_compress_threads_create();
> - qemu_thread_create(&s->thread, "migration", migration_thread, s,
> + qemu_thread_create(&s->thread, "qemu_vm_migration", migration_thread, s,
> QEMU_THREAD_JOINABLE);
Are you sure that works? For me it doesn't change the name.
There's a maximum length that I think is somewhere around 16 characters and that
name is too long.
Changing it to "qemu_migration" seems to work.
Dave
> s->migration_thread_running = true;
> }
> --
> 2.7.4
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2017-01-23 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 7:17 [Qemu-devel] [PATCH] Change name of live migration thread Pankaj Gupta
2017-01-23 5:40 ` Amit Shah
2017-01-23 9:18 ` Paolo Bonzini
2017-01-23 11:05 ` Pankaj Gupta
2017-01-23 8:42 ` Juan Quintela
2017-01-23 9:17 ` Dr. David Alan Gilbert [this message]
2017-01-23 10:58 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123091725.GB2098@work-vm \
--to=dgilbert@redhat.com \
--cc=amit.shah@redhat.com \
--cc=pagupta@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).