From: Stefan Hajnoczi <stefanha@gmail.com>
To: Haozhong Zhang <haozhong.zhang@intel.com>
Cc: qemu-devel@nongnu.org,
Xiao Guangrong <guangrong.xiao@linux.intel.com>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
imammedo@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging
Date: Mon, 23 Jan 2017 10:35:13 +0000 [thread overview]
Message-ID: <20170123103513.GE29186@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170113115651.17607-1-haozhong.zhang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
On Fri, Jan 13, 2017 at 07:56:51PM +0800, Haozhong Zhang wrote:
> The missing of 'nvdimm' in the machine type option '-M' means NVDIMM
> is disabled. QEMU should refuse to plug any NVDIMM device in this case
> and report the misconfiguration.
>
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
> Message-Id: 20170112110928.GF4621@stefanha-x1.localdomain
> Message-Id: 20170111093630.2088-1-stefanha@redhat.com
> ---
> hw/i386/pc.c | 5 +++++
> 1 file changed, 5 insertions(+)
Michael: Please add Haozhong's comment to the commit description when
merging:
"The behavior of NVDIMM on unsupported platform (HW/FW) is vendor
specific. For some vendors, it's undefined and the platform may do
anything. Thus, I think QEMU is free to choose the implementation.
Aborting QEMU (i.e. refusing to boot) is the easiest one."
This way we have a record that the behavior is okay according to the
spec and why we chose this option.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2017-01-23 10:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 11:56 [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging Haozhong Zhang
2017-01-13 12:20 ` Xiao Guangrong
2017-01-13 13:17 ` Stefan Hajnoczi
2017-01-13 13:37 ` Haozhong Zhang
2017-01-13 18:02 ` Eduardo Habkost
2017-01-16 5:55 ` Xiao Guangrong
2017-01-16 11:00 ` Stefan Hajnoczi
2017-01-20 0:55 ` Haozhong Zhang
2017-01-20 21:03 ` Eduardo Habkost
2017-01-23 10:35 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123103513.GE29186@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=ehabkost@redhat.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=haozhong.zhang@intel.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).