qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	"Daniel P. Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PULL v1 1/8] sockets: add ability to disable DNS resolution for InetSocketAddress
Date: Mon, 23 Jan 2017 14:26:22 +0000	[thread overview]
Message-ID: <20170123142629.11110-2-berrange@redhat.com> (raw)
In-Reply-To: <20170123142629.11110-1-berrange@redhat.com>

Add a 'numeric' flag to the InetSocketAddress struct to allow the
caller to indicate that DNS should be skipped for the host/port
fields. This is useful if the caller knows the address is already
numeric and wants to guarantee no (potentially blocking) DNS
lookups are attempted.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 qapi-schema.json    | 5 +++++
 util/qemu-sockets.c | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/qapi-schema.json b/qapi-schema.json
index ddc8783..ac55f4a 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3983,6 +3983,10 @@
 #
 # @port: port part of the address, or lowest port if @to is present
 #
+# @numeric: #optional true if the host/port are guaranteed to be numeric,
+#           false if name resolution should be attempted. Defaults to false.
+#           (Since 2.9)
+#
 # @to: highest port to try
 #
 # @ipv4: whether to accept IPv4 addresses, default try both IPv4 and IPv6
@@ -3997,6 +4001,7 @@
   'data': {
     'host': 'str',
     'port': 'str',
+    '*numeric':  'bool',
     '*to': 'uint16',
     '*ipv4': 'bool',
     '*ipv6': 'bool' } }
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index fe1d07a..d63b011 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -141,6 +141,9 @@ static int inet_listen_saddr(InetSocketAddress *saddr,
 
     memset(&ai,0, sizeof(ai));
     ai.ai_flags = AI_PASSIVE;
+    if (saddr->has_numeric && saddr->numeric) {
+        ai.ai_flags |= AI_NUMERICHOST | AI_NUMERICSERV;
+    }
     ai.ai_family = inet_ai_family_from_address(saddr, &err);
     ai.ai_socktype = SOCK_STREAM;
 
-- 
2.9.3

  reply	other threads:[~2017-01-23 14:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23 14:26 [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23 Daniel P. Berrange
2017-01-23 14:26 ` Daniel P. Berrange [this message]
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 2/8] io: stop incrementing reference in qio_task_get_source Daniel P. Berrange
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 3/8] io: fix typo in docs for QIOTask Daniel P. Berrange
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 4/8] io: add ability to associate an opaque "result" with with a task Daniel P. Berrange
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 5/8] io: add ability to associate an error " Daniel P. Berrange
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 6/8] io: change the QIOTask callback signature Daniel P. Berrange
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 7/8] io: remove Error parameter from QIOTask thread worker Daniel P. Berrange
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 8/8] io: introduce a DNS resolver API Daniel P. Berrange
2017-01-23 14:43 ` [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23 no-reply
2017-01-23 14:46 ` Peter Maydell
2017-01-23 15:24   ` Peter Maydell
2017-01-23 15:36     ` Daniel P. Berrange
2017-01-23 15:36   ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123142629.11110-2-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).