From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PULL v1 4/8] io: add ability to associate an opaque "result" with with a task
Date: Mon, 23 Jan 2017 14:26:25 +0000 [thread overview]
Message-ID: <20170123142629.11110-5-berrange@redhat.com> (raw)
In-Reply-To: <20170123142629.11110-1-berrange@redhat.com>
Currently there is no data associated with a successful
task completion. This adds an opaque pointer to the task
to store an arbitrary result.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
include/io/task.h | 27 +++++++++++++++++++++++++++
io/task.c | 20 ++++++++++++++++++++
2 files changed, 47 insertions(+)
diff --git a/include/io/task.h b/include/io/task.h
index 1407747..ece1372 100644
--- a/include/io/task.h
+++ b/include/io/task.h
@@ -240,6 +240,33 @@ void qio_task_abort(QIOTask *task,
/**
+ * qio_task_set_result_pointer:
+ * @task: the task struct
+ * @result: pointer to the result data
+ *
+ * Associate an opaque result with the task,
+ * which can later be retrieved with the
+ * qio_task_get_result_pointer() method
+ *
+ */
+void qio_task_set_result_pointer(QIOTask *task,
+ gpointer result,
+ GDestroyNotify notify);
+
+
+/**
+ * qio_task_get_result_pointer:
+ * @task: the task struct
+ *
+ * Retrieve the opaque result data associated
+ * with the task, if any.
+ *
+ * Returns: the task result, or NULL
+ */
+gpointer qio_task_get_result_pointer(QIOTask *task);
+
+
+/**
* qio_task_get_source:
* @task: the task struct
*
diff --git a/io/task.c b/io/task.c
index a763990..675e196 100644
--- a/io/task.c
+++ b/io/task.c
@@ -29,6 +29,8 @@ struct QIOTask {
QIOTaskFunc func;
gpointer opaque;
GDestroyNotify destroy;
+ gpointer result;
+ GDestroyNotify destroyResult;
};
@@ -57,6 +59,9 @@ static void qio_task_free(QIOTask *task)
if (task->destroy) {
task->destroy(task->opaque);
}
+ if (task->destroyResult) {
+ task->destroyResult(task->result);
+ }
object_unref(task->source);
g_free(task);
@@ -154,6 +159,21 @@ void qio_task_abort(QIOTask *task,
}
+void qio_task_set_result_pointer(QIOTask *task,
+ gpointer result,
+ GDestroyNotify destroy)
+{
+ task->result = result;
+ task->destroyResult = destroy;
+}
+
+
+gpointer qio_task_get_result_pointer(QIOTask *task)
+{
+ return task->result;
+}
+
+
Object *qio_task_get_source(QIOTask *task)
{
return task->source;
--
2.9.3
next prev parent reply other threads:[~2017-01-23 14:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 14:26 [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23 Daniel P. Berrange
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 1/8] sockets: add ability to disable DNS resolution for InetSocketAddress Daniel P. Berrange
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 2/8] io: stop incrementing reference in qio_task_get_source Daniel P. Berrange
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 3/8] io: fix typo in docs for QIOTask Daniel P. Berrange
2017-01-23 14:26 ` Daniel P. Berrange [this message]
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 5/8] io: add ability to associate an error with a task Daniel P. Berrange
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 6/8] io: change the QIOTask callback signature Daniel P. Berrange
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 7/8] io: remove Error parameter from QIOTask thread worker Daniel P. Berrange
2017-01-23 14:26 ` [Qemu-devel] [PULL v1 8/8] io: introduce a DNS resolver API Daniel P. Berrange
2017-01-23 14:43 ` [Qemu-devel] [PULL v1 0/8] Merge io/ 2017-01-23 no-reply
2017-01-23 14:46 ` Peter Maydell
2017-01-23 15:24 ` Peter Maydell
2017-01-23 15:36 ` Daniel P. Berrange
2017-01-23 15:36 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123142629.11110-5-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).