From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>,
Marcel Apfelbaum <marcel@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PULL 10/13] qemu-options: Rename variables on the -numa "cpus" option
Date: Mon, 23 Jan 2017 21:27:35 -0200 [thread overview]
Message-ID: <20170123232738.20796-11-ehabkost@redhat.com> (raw)
In-Reply-To: <20170123232738.20796-1-ehabkost@redhat.com>
Use @var{firstcpu} and @var{lastcpu} to make the metasyntatic
variables a bit clearer. While doing this, use @var only around
the metasyntatic variables, not including the square brackets and
hyphen.
The semantics of the "cpus" option will be clarified by rewriting
the whole -numa documentation in a follow-up patch.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170123180632.28942-2-ehabkost@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
qemu-options.hx | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 80df52651a..780528d6ad 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -119,11 +119,11 @@ specifies the maximum number of hotpluggable CPUs.
ETEXI
DEF("numa", HAS_ARG, QEMU_OPTION_numa,
- "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n"
- "-numa node[,memdev=id][,cpus=cpu[-cpu]][,nodeid=node]\n", QEMU_ARCH_ALL)
+ "-numa node[,mem=size][,cpus=firstcpu[-lastcpu]][,nodeid=node]\n"
+ "-numa node[,memdev=id][,cpus=firstcpu[-lastcpu]][,nodeid=node]\n", QEMU_ARCH_ALL)
STEXI
-@item -numa node[,mem=@var{size}][,cpus=@var{cpu[-cpu]}][,nodeid=@var{node}]
-@itemx -numa node[,memdev=@var{id}][,cpus=@var{cpu[-cpu]}][,nodeid=@var{node}]
+@item -numa node[,mem=@var{size}][,cpus=@var{firstcpu}[-@var{lastcpu}]][,nodeid=@var{node}]
+@itemx -numa node[,memdev=@var{id}][,cpus=@var{firstcpu}[-@var{lastcpu}]][,nodeid=@var{node}]
@findex -numa
Simulate a multi node NUMA system. If @samp{mem}, @samp{memdev}
and @samp{cpus} are omitted, resources are split equally. Also, note
--
2.11.0.259.g40922b1
next prev parent reply other threads:[~2017-01-23 23:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 23:27 [Qemu-devel] [PULL 00/13] x86, machine, numa queue (2017-01-23) Eduardo Habkost
2017-01-23 23:27 ` [Qemu-devel] [PULL 01/13] x86: add AVX512_VPOPCNTDQ features Eduardo Habkost
2017-01-23 23:27 ` [Qemu-devel] [PULL 02/13] i386: Remove AMD feature flag aliases from Opteron models Eduardo Habkost
2017-01-23 23:27 ` [Qemu-devel] [PULL 03/13] i386: Return migration-safe field on query-cpu-definitions Eduardo Habkost
2017-01-23 23:27 ` [Qemu-devel] [PULL 04/13] vl: Ensure the numa_post_machine_init func in the appropriate location Eduardo Habkost
2017-01-23 23:27 ` [Qemu-devel] [PULL 05/13] arch_init: Remove unnecessary default_config_files table Eduardo Habkost
2017-01-23 23:27 ` [Qemu-devel] [PULL 06/13] pc: cleanup: move smbios_set_cpuid() into pc_build_smbios() Eduardo Habkost
2017-01-23 23:27 ` [Qemu-devel] [PULL 07/13] pc: don't return cpu pointer from pc_new_cpu() as it's not needed anymore Eduardo Habkost
2017-01-23 23:27 ` [Qemu-devel] [PULL 08/13] machine: Make possible_cpu_arch_ids() return const pointer Eduardo Habkost
2017-01-23 23:27 ` [Qemu-devel] [PULL 09/13] MAINTAINERS: Add an entry for hw/core/null-machine.c Eduardo Habkost
2017-01-23 23:27 ` Eduardo Habkost [this message]
2017-01-23 23:27 ` [Qemu-devel] [PULL 11/13] hw/core/null-machine: Add the possibility to instantiate a CPU and RAM Eduardo Habkost
2017-01-23 23:27 ` [Qemu-devel] [PULL 12/13] kvm: Simplify invtsc check Eduardo Habkost
2017-01-23 23:27 ` [Qemu-devel] [PULL 13/13] kvm: Allow invtsc migration if tsc-khz is set explicitly Eduardo Habkost
2017-01-24 13:24 ` [Qemu-devel] [PULL 00/13] x86, machine, numa queue (2017-01-23) Peter Maydell
2017-01-24 13:38 ` Peter Maydell
2017-01-24 16:20 ` Markus Armbruster
2017-01-24 16:57 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123232738.20796-11-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).