From: Sam Bobroff <sam.bobroff@au1.ibm.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] update-linux-headers.sh fails on clean kernel dir
Date: Tue, 24 Jan 2017 15:39:41 +1100 [thread overview]
Message-ID: <20170124043941.GA12671@tungsten.ozlabs.ibm.com> (raw)
Hi QEMU developers,
If I run scripts/update-linux-headers.sh from a clean checkout of QEMU
and point it at a clean checkout of a recent linux kernel (4.10-rc1 or
later), it fails:
$ scripts/update-linux-headers.sh ~/tmp/linux/
...
scripts/Makefile.headersinst:62: *** Missing generated UAPI file ./arch/arm/include/generated/uapi/asm/unistd-common.h. Stop.
This seems to be because the script passes the arch to the kernel
makefile using "SRCARCH" rather than "ARCH".
(SRCARCH seems to be intended as an internal value, and setting it does
not propagate the setting to ARCH. Because ARCH is left empty, the
prerequisites that should generate unistd-common.h fail. If ARCH is set,
SRCARCH is set automatically and everything works.)
Changing the script to use "ARCH" seems to fixe the problem.
(Note: when testing this be careful: unistd-common.h is not removed by
"make clean" in the kernel directory.)
Does this seem correct?
Should I send a patch even though it's a very small change?
Cheers,
Sam.
next reply other threads:[~2017-01-24 4:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 4:39 Sam Bobroff [this message]
2017-01-24 10:32 ` [Qemu-devel] update-linux-headers.sh fails on clean kernel dir Marc-André Lureau
2017-01-25 0:25 ` Sam Bobroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124043941.GA12671@tungsten.ozlabs.ibm.com \
--to=sam.bobroff@au1.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).