Re: [Qemu-devel] [PATCH 04/17] block: move AioContext and QEMUTimer to libqemuutil

["Daniel P. Berrange" <berrange@redhat.com>]

On Fri, Jan 20, 2017 at 05:43:09PM +0100, Paolo Bonzini wrote:
> AioContext is fairly self contained, the only dependency is QEMUTimer but
> that in turn doesn't need anything else.  So move them out of block-obj-y
> to avoid introducing a dependency from io/ to block-obj-y.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>         v1->v2: new patch [Daniel]
> 
>  Makefile.objs                       |  5 +---
>  block/io.c                          | 29 -------------------
>  stubs/Makefile.objs                 |  2 ++
>  stubs/linux-aio.c                   | 32 +++++++++++++++++++++
>  stubs/main-loop.c                   |  8 ++++++
>  stubs/set-fd-handler.c              | 11 --------
>  tests/Makefile.include              | 13 ++++-----
>  util/Makefile.objs                  |  5 +++-
>  aio-posix.c => util/aio-posix.c     |  0
>  aio-win32.c => util/aio-win32.c     |  0
>  util/aiocb.c                        | 55 +++++++++++++++++++++++++++++++++++++
>  async.c => util/async.c             |  3 +-
>  qemu-timer.c => util/qemu-timer.c   |  0
>  thread-pool.c => util/thread-pool.c |  0
>  14 files changed, 110 insertions(+), 53 deletions(-)
>  create mode 100644 stubs/linux-aio.c
>  create mode 100644 stubs/main-loop.c
>  rename aio-posix.c => util/aio-posix.c (100%)
>  rename aio-win32.c => util/aio-win32.c (100%)
>  create mode 100644 util/aiocb.c
>  rename async.c => util/async.c (99%)
>  rename qemu-timer.c => util/qemu-timer.c (100%)
>  rename thread-pool.c => util/thread-pool.c (100%)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|