From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVxXm-0003yN-IY for qemu-devel@nongnu.org; Tue, 24 Jan 2017 04:37:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVxXl-0000DC-Lo for qemu-devel@nongnu.org; Tue, 24 Jan 2017 04:37:38 -0500 Date: Tue, 24 Jan 2017 17:36:43 +0800 From: Fam Zheng Message-ID: <20170124093643.GA14811@lemon.Home> References: <1482503344-6424-1-git-send-email-vsementsov@virtuozzo.com> <1482503344-6424-9-git-send-email-vsementsov@virtuozzo.com> <20170124075949.GD27126@lemon.Home> <22f99aae-0968-286f-186c-0eaefadbe649@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22f99aae-0968-286f-186c-0eaefadbe649@virtuozzo.com> Subject: Re: [Qemu-devel] [PATCH 08/21] backup: skip unallocated clusters for full mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, kwolf@redhat.com, mreitz@redhat.com, jsnow@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com, jcody@redhat.com On Tue, 01/24 12:18, Vladimir Sementsov-Ogievskiy wrote: > 24.01.2017 10:59, Fam Zheng wrote: > > On Fri, 12/23 17:28, Vladimir Sementsov-Ogievskiy wrote: > > > diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/055 > > > index 1d3fd04..388b7b2 100755 > > > --- a/tests/qemu-iotests/055 > > > +++ b/tests/qemu-iotests/055 > > > @@ -30,6 +30,7 @@ target_img = os.path.join(iotests.test_dir, 'target.img') > > > blockdev_target_img = os.path.join(iotests.test_dir, 'blockdev-target.img') > > > image_len = 64 * 1024 * 1024 # MB > > > +pause_write = '3M' > > > def setUpModule(): > > > qemu_img('create', '-f', iotests.imgfmt, test_img, str(image_len)) > > > @@ -39,6 +40,7 @@ def setUpModule(): > > > qemu_io('-f', iotests.imgfmt, '-c', 'write -P0xd5 1M 32k', test_img) > > > qemu_io('-f', iotests.imgfmt, '-c', 'write -P0xdc 32M 124k', test_img) > > > qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x33 67043328 64k', test_img) > > > + qemu_io('-f', iotests.imgfmt, '-c', 'write -P0xdc 40M ' + pause_write, test_img) > > What does this iotest change do? > > Without this backup block-job finishes before the next query to it from test > and test fails. This is a wide problem I suffer of on the way of backup > improvement and it should have better solution then adjusting amount of data > being copied... You can use blkdebug to pause I/O before querying the block job, or simply throttle it down. Fam