From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cW3zU-0005Ud-Lz for qemu-devel@nongnu.org; Tue, 24 Jan 2017 11:30:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cW3zQ-00050r-FC for qemu-devel@nongnu.org; Tue, 24 Jan 2017 11:30:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42846) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cW3zQ-00050R-8y for qemu-devel@nongnu.org; Tue, 24 Jan 2017 11:30:36 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 98FCD7FB71 for ; Tue, 24 Jan 2017 16:30:35 +0000 (UTC) Date: Tue, 24 Jan 2017 18:30:33 +0200 From: "Michael S. Tsirkin" Message-ID: <20170124183019-mutt-send-email-mst@kernel.org> References: <1484135195-29232-1-git-send-email-marcel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH V2] hw/pci: disable pci-bridge's shpc by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: qemu-devel@nongnu.org On Tue, Jan 24, 2017 at 06:23:49PM +0200, Marcel Apfelbaum wrote: > On 01/11/2017 01:46 PM, Marcel Apfelbaum wrote: > > The shpc component is optional while ACPI hotplug is used > > for hot-plugging PCI devices into a PCI-PCI bridge. > > Disabling the shpc by default will make slot 0 usable at boot time > > and not only for hot-plug, without loosing any functionality. > > Older machines will have shpc enabled for compatibility reasons. > > > > Signed-off-by: Marcel Apfelbaum > > --- > > v1 -> v2: > > - Moved the compat property to HW_COMPAT_2_8 > > > > Hi Michael, > Can you please merge this? > > Thanks, > Marcel Yes but pls rebase to master. > > hw/pci-bridge/pci_bridge_dev.c | 2 +- > > include/hw/compat.h | 6 +++++- > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c > > index 5dbd933..647ad80 100644 > > --- a/hw/pci-bridge/pci_bridge_dev.c > > +++ b/hw/pci-bridge/pci_bridge_dev.c > > @@ -163,7 +163,7 @@ static Property pci_bridge_dev_properties[] = { > > DEFINE_PROP_ON_OFF_AUTO(PCI_BRIDGE_DEV_PROP_MSI, PCIBridgeDev, msi, > > ON_OFF_AUTO_AUTO), > > DEFINE_PROP_BIT(PCI_BRIDGE_DEV_PROP_SHPC, PCIBridgeDev, flags, > > - PCI_BRIDGE_DEV_F_SHPC_REQ, true), > > + PCI_BRIDGE_DEV_F_SHPC_REQ, false), > > DEFINE_PROP_END_OF_LIST(), > > }; > > > > diff --git a/include/hw/compat.h b/include/hw/compat.h > > index 4fe44d1..428c127 100644 > > --- a/include/hw/compat.h > > +++ b/include/hw/compat.h > > @@ -2,7 +2,11 @@ > > #define HW_COMPAT_H > > > > #define HW_COMPAT_2_8 \ > > - /* empty */ > > + {\ > > + .driver = "pci-bridge",\ > > + .property = "shpc",\ > > + .value = "on",\ > > + }, > > > > #define HW_COMPAT_2_7 \ > > {\ > >