* [Qemu-devel] [PATCH] s390x/flic: fix compilation of kvm flic
@ 2017-01-25 12:17 Cornelia Huck
2017-01-25 14:45 ` Dr. David Alan Gilbert
2017-01-26 10:56 ` Cornelia Huck
0 siblings, 2 replies; 3+ messages in thread
From: Cornelia Huck @ 2017-01-25 12:17 UTC (permalink / raw)
To: qemu-devel; +Cc: borntraeger, agraf, jfrei, duanj, dgilbert, Cornelia Huck
2c21ee7 ("migration: extend VMStateInfo") missed a void -> int
return conversion for kvm_flic_save().
Fixes: 2c21ee7 ("migration: extend VMStateInfo")
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
hw/intc/s390_flic_kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic_kvm.c
index da8e4dfab6..e86a84e49a 100644
--- a/hw/intc/s390_flic_kvm.c
+++ b/hw/intc/s390_flic_kvm.c
@@ -303,7 +303,7 @@ static int kvm_flic_save(QEMUFile *f, void *opaque, size_t size,
* migration state */
error_report("flic: couldn't allocate memory");
qemu_put_be64(f, FLIC_FAILED);
- return;
+ return 0;
}
count = __get_all_irqs(flic, &buf, len);
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/flic: fix compilation of kvm flic
2017-01-25 12:17 [Qemu-devel] [PATCH] s390x/flic: fix compilation of kvm flic Cornelia Huck
@ 2017-01-25 14:45 ` Dr. David Alan Gilbert
2017-01-26 10:56 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2017-01-25 14:45 UTC (permalink / raw)
To: Cornelia Huck; +Cc: qemu-devel, borntraeger, agraf, jfrei, duanj
* Cornelia Huck (cornelia.huck@de.ibm.com) wrote:
> 2c21ee7 ("migration: extend VMStateInfo") missed a void -> int
> return conversion for kvm_flic_save().
>
> Fixes: 2c21ee7 ("migration: extend VMStateInfo")
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
> hw/intc/s390_flic_kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic_kvm.c
> index da8e4dfab6..e86a84e49a 100644
> --- a/hw/intc/s390_flic_kvm.c
> +++ b/hw/intc/s390_flic_kvm.c
> @@ -303,7 +303,7 @@ static int kvm_flic_save(QEMUFile *f, void *opaque, size_t size,
> * migration state */
> error_report("flic: couldn't allocate memory");
> qemu_put_be64(f, FLIC_FAILED);
> - return;
> + return 0;
> }
>
> count = __get_all_irqs(flic, &buf, len);
> --
> 2.11.0
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
as discussed, sort out an error return value later.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/flic: fix compilation of kvm flic
2017-01-25 12:17 [Qemu-devel] [PATCH] s390x/flic: fix compilation of kvm flic Cornelia Huck
2017-01-25 14:45 ` Dr. David Alan Gilbert
@ 2017-01-26 10:56 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2017-01-26 10:56 UTC (permalink / raw)
To: qemu-devel; +Cc: borntraeger, agraf, jfrei, duanj, dgilbert
On Wed, 25 Jan 2017 13:17:10 +0100
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> 2c21ee7 ("migration: extend VMStateInfo") missed a void -> int
> return conversion for kvm_flic_save().
>
> Fixes: 2c21ee7 ("migration: extend VMStateInfo")
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
> hw/intc/s390_flic_kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic_kvm.c
> index da8e4dfab6..e86a84e49a 100644
> --- a/hw/intc/s390_flic_kvm.c
> +++ b/hw/intc/s390_flic_kvm.c
> @@ -303,7 +303,7 @@ static int kvm_flic_save(QEMUFile *f, void *opaque, size_t size,
> * migration state */
> error_report("flic: couldn't allocate memory");
> qemu_put_be64(f, FLIC_FAILED);
> - return;
> + return 0;
> }
>
> count = __get_all_irqs(flic, &buf, len);
Added to my s390-next branch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-26 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-25 12:17 [Qemu-devel] [PATCH] s390x/flic: fix compilation of kvm flic Cornelia Huck
2017-01-25 14:45 ` Dr. David Alan Gilbert
2017-01-26 10:56 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).