From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWVYl-0006nR-0A for qemu-devel@nongnu.org; Wed, 25 Jan 2017 16:56:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWVYh-0003ZM-PX for qemu-devel@nongnu.org; Wed, 25 Jan 2017 16:56:55 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:54799) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cWVYh-0003Yf-Ej for qemu-devel@nongnu.org; Wed, 25 Jan 2017 16:56:51 -0500 From: Laurent Vivier Date: Wed, 25 Jan 2017 22:56:36 +0100 Message-Id: <20170125215637.2992-3-laurent@vivier.eu> In-Reply-To: <20170125215637.2992-1-laurent@vivier.eu> References: <20170125215637.2992-1-laurent@vivier.eu> Subject: [Qemu-devel] [PATCH v2 2/3] linux-user: fix "apt-get update" on linux-user hppa List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Riku Voipio , John Paul Adrian Glaubitz , Laurent Vivier apt-get was hanging on linux-user hppa. strace has shown the netlink data stream was not correctly byte swapped. It appears the fd translator function is unregistered just after it has been registered, so the translator function is not called. This patch removes the fd_trans_unregister() after the do_socket() in the TARGET_NR_socket case. This fd_trans_unregister() was added by commit e36800c linux-user: add signalfd/signalfd4 syscalls when do_socket() was not registering any fd translator. And as now it is, we must remove this fd_trans_unregister() to keep them. Reported-by: John Paul Adrian Glaubitz Signed-off-by: Laurent Vivier Tested-by: John Paul Adrian Glaubitz --- linux-user/syscall.c | 1 - 1 file changed, 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 11a311f..9be8e95 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -9343,7 +9343,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, #ifdef TARGET_NR_socket case TARGET_NR_socket: ret = do_socket(arg1, arg2, arg3); - fd_trans_unregister(ret); break; #endif #ifdef TARGET_NR_socketpair -- 2.9.3