From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWhrT-0008BK-AA for qemu-devel@nongnu.org; Thu, 26 Jan 2017 06:05:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWhrS-0003ne-EC for qemu-devel@nongnu.org; Thu, 26 Jan 2017 06:05:03 -0500 From: "Daniel P. Berrange" Date: Thu, 26 Jan 2017 11:04:35 +0000 Message-Id: <20170126110435.2777-7-berrange@redhat.com> In-Reply-To: <20170126110435.2777-1-berrange@redhat.com> References: <20170126110435.2777-1-berrange@redhat.com> Subject: [Qemu-devel] [PATCH v1 6/6] qemu-img: copy *key-secret opts when opening newly created files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Max Reitz , Kevin Wolf , "Daniel P. Berrange" The qemu-img dd/convert commands will create a image file and then try to open it. Historically it has been possible to open new files without passing any options. With encrypted files though, the *key-secret options are mandatory, so we need to provide those options when opening the newlky created file. Signed-off-by: Daniel P. Berrange --- qemu-img.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 47 insertions(+), 4 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index a751781..130cec7 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -317,6 +317,49 @@ static BlockBackend *img_open_file(const char *filename, } +static int img_add_key_secrets(void *opaque, + const char *name, const char *value, + Error **errp) +{ + QDict **options = opaque; + + if (g_str_has_suffix(name, "key-secret")) { + if (!*options) { + *options = qdict_new(); + } + qdict_put(*options, name, qstring_from_str(value)); + } + + return 0; +} + +static BlockBackend *img_open_new_file(const char *filename, + QemuOpts *create_opts, + const char *fmt, int flags, + bool writethrough, bool quiet) +{ + BlockBackend *blk; + Error *local_err = NULL; + QDict *options = NULL; + + if (fmt) { + options = qdict_new(); + qdict_put(options, "driver", qstring_from_str(fmt)); + } + + qemu_opt_foreach(create_opts, img_add_key_secrets, &options, NULL); + + blk = blk_new_open(filename, NULL, options, flags, &local_err); + if (!blk) { + error_reportf_err(local_err, "Could not open '%s': ", filename); + return NULL; + } + blk_set_enable_write_cache(blk, !writethrough); + + return blk; +} + + static BlockBackend *img_open(bool image_opts, const char *filename, const char *fmt, int flags, bool writethrough, @@ -2113,8 +2156,8 @@ static int img_convert(int argc, char **argv) * That has to wait for bdrv_create to be improved * to allow filenames in option syntax */ - out_blk = img_open_file(out_filename, out_fmt, - flags, writethrough, quiet); + out_blk = img_open_new_file(out_filename, opts, out_fmt, + flags, writethrough, quiet); } if (!out_blk) { ret = -1; @@ -4179,8 +4222,8 @@ static int img_dd(int argc, char **argv) * That has to wait for bdrv_create to be improved * to allow filenames in option syntax */ - blk2 = img_open_file(out.filename, out_fmt, - BDRV_O_RDWR, false, false); + blk2 = img_open_new_file(out.filename, opts, out_fmt, + BDRV_O_RDWR, false, false); } if (!blk2) { -- 2.9.3