From: Kashyap Chamarthy <kchamart@redhat.com>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: thuth@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com,
quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migrate: Migration aborts abruptly for machine "none"
Date: Thu, 26 Jan 2017 12:25:24 +0100 [thread overview]
Message-ID: <20170126112524.ww27c3f6x26hxcup@eukaryote> (raw)
In-Reply-To: <1485422212-31546-1-git-send-email-ashijeetacharya@gmail.com>
On Thu, Jan 26, 2017 at 02:46:52PM +0530, Ashijeet Acharya wrote:
> Migration of a "none" machine with no RAM crashes abruptly as
> bitmap_new() fails and thus aborts. Instead, place a check for
> last_ram_offset() being '0' at the start of ram_save_setup() and
> error out with a meaningful error message.
>
> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
> ---
> migration/ram.c | 5 +++++
> 1 file changed, 5 insertions(+)
You state the problem in the one-line Git commit summary message, it's
usually preferred to summarize the _fix_ that you're making :-). If the
below variant sounds any better, maybe the maintainer can reword it upon
applying:
migrate: Gracefully handle crash of a 'none' machine with no RAM
[...]
--
/kashyap
next prev parent reply other threads:[~2017-01-26 11:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 9:16 [Qemu-devel] [PATCH] migrate: Migration aborts abruptly for machine "none" Ashijeet Acharya
2017-01-26 11:25 ` Kashyap Chamarthy [this message]
2017-01-26 19:41 ` Dr. David Alan Gilbert
2017-01-27 9:37 ` Daniel P. Berrange
2017-01-27 9:46 ` Dr. David Alan Gilbert
2017-01-27 9:57 ` Daniel P. Berrange
2017-01-27 9:52 ` Ashijeet Acharya
2017-01-27 9:57 ` Daniel P. Berrange
2017-01-28 18:41 ` Greg Kurz
2017-01-28 19:36 ` Ashijeet Acharya
2017-01-29 13:03 ` Greg Kurz
2017-01-29 13:19 ` Ashijeet Acharya
2017-01-30 20:48 ` Paolo Bonzini
2017-02-01 17:53 ` Ashijeet Acharya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126112524.ww27c3f6x26hxcup@eukaryote \
--to=kchamart@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).