From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, agraf@suse.de, jfrei@linux.vnet.ibm.com,
duanj@linux.vnet.ibm.com, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH] s390x/flic: fix compilation of kvm flic
Date: Thu, 26 Jan 2017 11:56:34 +0100 [thread overview]
Message-ID: <20170126115634.2a8c379d.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20170125121710.13561-1-cornelia.huck@de.ibm.com>
On Wed, 25 Jan 2017 13:17:10 +0100
Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> 2c21ee7 ("migration: extend VMStateInfo") missed a void -> int
> return conversion for kvm_flic_save().
>
> Fixes: 2c21ee7 ("migration: extend VMStateInfo")
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
> hw/intc/s390_flic_kvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic_kvm.c
> index da8e4dfab6..e86a84e49a 100644
> --- a/hw/intc/s390_flic_kvm.c
> +++ b/hw/intc/s390_flic_kvm.c
> @@ -303,7 +303,7 @@ static int kvm_flic_save(QEMUFile *f, void *opaque, size_t size,
> * migration state */
> error_report("flic: couldn't allocate memory");
> qemu_put_be64(f, FLIC_FAILED);
> - return;
> + return 0;
> }
>
> count = __get_all_irqs(flic, &buf, len);
Added to my s390-next branch.
prev parent reply other threads:[~2017-01-26 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 12:17 [Qemu-devel] [PATCH] s390x/flic: fix compilation of kvm flic Cornelia Huck
2017-01-25 14:45 ` Dr. David Alan Gilbert
2017-01-26 10:56 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126115634.2a8c379d.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@redhat.com \
--cc=duanj@linux.vnet.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).