From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45334)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1cWjAL-00006i-9X
	for qemu-devel@nongnu.org; Thu, 26 Jan 2017 07:28:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1cWjAK-0002DM-GE
	for qemu-devel@nongnu.org; Thu, 26 Jan 2017 07:28:37 -0500
Date: Thu, 26 Jan 2017 20:28:24 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20170126122824.GA23095@lemon.Home>
References: <20170126110435.2777-1-berrange@redhat.com>
	<20170126110435.2777-3-berrange@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170126110435.2777-3-berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1 2/6] qemu-img: fix --image-opts usage
 with dd command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>

On Thu, 01/26 11:04, Daniel P. Berrange wrote:
> The --image-opts flag can only be used to affect the parsing
> of the source image. The target image has to be specified in
> the traditional style regardless, since it needs to be passed
> to the brdv_create() API which does not support the new style

"bdrv_create", if you respin :)

> opts.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  qemu-img.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 391a141..629f9e9 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -4098,8 +4098,13 @@ static int img_dd(int argc, char **argv)
>          goto out;
>      }
>  
> -    blk2 = img_open(image_opts, out.filename, out_fmt, BDRV_O_RDWR,
> -                    false, false);
> +    /* TODO, we can't honour --image-opts for the target,
> +     * since it needs to be given in a format compatible
> +     * with the bdrv_create() call above which does not
> +     * support image-opts style.
> +     */
> +    blk2 = img_open_file(out.filename, out_fmt, BDRV_O_RDWR,
> +                         false, false);
>  
>      if (!blk2) {
>          ret = -1;
> -- 
> 2.9.3
> 
>