* [Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var
@ 2017-01-26 15:38 Stefan Hajnoczi
2017-11-02 6:31 ` Thomas Huth
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Hajnoczi @ 2017-01-26 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Stefan Hajnoczi
This hunk should not have been merged but I forgot to remove it. Let's
remove it before it slips into a QEMU release.
¯\_(ツ)_/¯
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
aio-posix.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/aio-posix.c b/aio-posix.c
index 9453d83..9a6348b 100644
--- a/aio-posix.c
+++ b/aio-posix.c
@@ -723,13 +723,6 @@ bool aio_poll(AioContext *ctx, bool blocking)
void aio_context_setup(AioContext *ctx)
{
- /* TODO remove this in final patch submission */
- if (getenv("QEMU_AIO_POLL_MAX_NS")) {
- fprintf(stderr, "The QEMU_AIO_POLL_MAX_NS environment variable has "
- "been replaced with -object iothread,poll-max-ns=NUM\n");
- exit(1);
- }
-
#ifdef CONFIG_EPOLL_CREATE1
assert(!ctx->epollfd);
ctx->epollfd = epoll_create1(EPOLL_CLOEXEC);
--
2.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var
2017-01-26 15:38 [Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var Stefan Hajnoczi
@ 2017-11-02 6:31 ` Thomas Huth
2017-11-03 15:16 ` Stefan Hajnoczi
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2017-11-02 6:31 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel; +Cc: Paolo Bonzini, QEMU Trivial
On 26.01.2017 16:38, Stefan Hajnoczi wrote:
> This hunk should not have been merged but I forgot to remove it. Let's
> remove it before it slips into a QEMU release.
Too late - looks like this patch has never been committed :-(
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> aio-posix.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/aio-posix.c b/aio-posix.c
> index 9453d83..9a6348b 100644
> --- a/aio-posix.c
> +++ b/aio-posix.c
> @@ -723,13 +723,6 @@ bool aio_poll(AioContext *ctx, bool blocking)
>
> void aio_context_setup(AioContext *ctx)
> {
> - /* TODO remove this in final patch submission */
> - if (getenv("QEMU_AIO_POLL_MAX_NS")) {
> - fprintf(stderr, "The QEMU_AIO_POLL_MAX_NS environment variable has "
> - "been replaced with -object iothread,poll-max-ns=NUM\n");
> - exit(1);
> - }
> -
> #ifdef CONFIG_EPOLL_CREATE1
> assert(!ctx->epollfd);
> ctx->epollfd = epoll_create1(EPOLL_CLOEXEC);
>
Could we get this at least added for QEMU 2.11 ?
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var
2017-11-02 6:31 ` Thomas Huth
@ 2017-11-03 15:16 ` Stefan Hajnoczi
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2017-11-03 15:16 UTC (permalink / raw)
To: Thomas Huth; +Cc: Stefan Hajnoczi, qemu-devel, QEMU Trivial, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]
On Thu, Nov 02, 2017 at 07:31:13AM +0100, Thomas Huth wrote:
> On 26.01.2017 16:38, Stefan Hajnoczi wrote:
> > This hunk should not have been merged but I forgot to remove it. Let's
> > remove it before it slips into a QEMU release.
>
> Too late - looks like this patch has never been committed :-(
>
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > aio-posix.c | 7 -------
> > 1 file changed, 7 deletions(-)
> >
> > diff --git a/aio-posix.c b/aio-posix.c
> > index 9453d83..9a6348b 100644
> > --- a/aio-posix.c
> > +++ b/aio-posix.c
> > @@ -723,13 +723,6 @@ bool aio_poll(AioContext *ctx, bool blocking)
> >
> > void aio_context_setup(AioContext *ctx)
> > {
> > - /* TODO remove this in final patch submission */
> > - if (getenv("QEMU_AIO_POLL_MAX_NS")) {
> > - fprintf(stderr, "The QEMU_AIO_POLL_MAX_NS environment variable has "
> > - "been replaced with -object iothread,poll-max-ns=NUM\n");
> > - exit(1);
> > - }
> > -
> > #ifdef CONFIG_EPOLL_CREATE1
> > assert(!ctx->epollfd);
> > ctx->epollfd = epoll_create1(EPOLL_CLOEXEC);
> >
>
> Could we get this at least added for QEMU 2.11 ?
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
I am sending a new version of this patch (it needs to be rebased).
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var
@ 2017-11-03 15:40 Stefan Hajnoczi
2017-11-06 13:04 ` Stefan Hajnoczi
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Hajnoczi @ 2017-11-03 15:40 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-block, thuth, Stefan Hajnoczi
This hunk should not have been merged but I forgot to remove it. Let's
remove it before it slips into a QEMU release.
¯\_(ツ)_/¯
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
util/aio-posix.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/util/aio-posix.c b/util/aio-posix.c
index 5946ac09f0..1427f49b4a 100644
--- a/util/aio-posix.c
+++ b/util/aio-posix.c
@@ -701,13 +701,6 @@ bool aio_poll(AioContext *ctx, bool blocking)
void aio_context_setup(AioContext *ctx)
{
- /* TODO remove this in final patch submission */
- if (getenv("QEMU_AIO_POLL_MAX_NS")) {
- fprintf(stderr, "The QEMU_AIO_POLL_MAX_NS environment variable has "
- "been replaced with -object iothread,poll-max-ns=NUM\n");
- exit(1);
- }
-
#ifdef CONFIG_EPOLL_CREATE1
assert(!ctx->epollfd);
ctx->epollfd = epoll_create1(EPOLL_CLOEXEC);
--
2.13.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-06 13:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-26 15:38 [Qemu-devel] [PATCH] aio-posix: drop QEMU_AIO_POLL_MAX_NS env var Stefan Hajnoczi
2017-11-02 6:31 ` Thomas Huth
2017-11-03 15:16 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2017-11-03 15:40 Stefan Hajnoczi
2017-11-06 13:04 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).