From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P . Berrange" <berrange@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v2 1/2] qapi: add missing trace_visit_type_enum() call
Date: Thu, 26 Jan 2017 17:16:12 +0000 [thread overview]
Message-ID: <20170126171613.1399-2-stefanha@redhat.com> (raw)
In-Reply-To: <20170126171613.1399-1-stefanha@redhat.com>
A trace event exists for enums but it's never called. This patch fixes
this oversight so that enums are traced just like the other QAPI types.
Suggested-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
qapi/qapi-visit-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c
index 63bd97b..e6e93f0 100644
--- a/qapi/qapi-visit-core.c
+++ b/qapi/qapi-visit-core.c
@@ -374,6 +374,7 @@ void visit_type_enum(Visitor *v, const char *name, int *obj,
const char *const strings[], Error **errp)
{
assert(obj && strings);
+ trace_visit_type_enum(v, name, obj);
switch (v->type) {
case VISITOR_INPUT:
input_type_enum(v, name, obj, strings, errp);
--
2.9.3
next prev parent reply other threads:[~2017-01-26 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 17:16 [Qemu-devel] [PATCH v2 0/2] trace: clean up trace-events files Stefan Hajnoczi
2017-01-26 17:16 ` Stefan Hajnoczi [this message]
2017-01-26 17:49 ` [Qemu-devel] [PATCH v2 1/2] qapi: add missing trace_visit_type_enum() call Eric Blake
2017-01-26 17:16 ` [Qemu-devel] [PATCH v2 2/2] trace: clean up trace-events files Stefan Hajnoczi
2017-01-26 18:55 ` Eric Blake
2017-01-31 17:15 ` [Qemu-devel] [PATCH v2 0/2] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126171613.1399-2-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).