From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, eblake@redhat.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH v2 16/41] char: remove chr_free
Date: Mon, 30 Jan 2017 17:39:29 +0400 [thread overview]
Message-ID: <20170130133954.31353-17-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20170130133954.31353-1-marcandre.lureau@redhat.com>
Now it uses Object instance_finalize instead.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
include/sysemu/char.h | 8 --------
qemu-char.c | 10 +---------
2 files changed, 1 insertion(+), 17 deletions(-)
diff --git a/include/sysemu/char.h b/include/sysemu/char.h
index da0e7dd494..5e5594f305 100644
--- a/include/sysemu/char.h
+++ b/include/sysemu/char.h
@@ -185,13 +185,6 @@ Chardev *qemu_chr_new_noreplay(const char *label, const char *filename);
void qemu_chr_delete(Chardev *chr);
/**
- * @qemu_chr_free:
- *
- * Destroy a character backend.
- */
-void qemu_chr_free(Chardev *chr);
-
-/**
* @qemu_chr_fe_set_echo:
*
* Ask the backend to override its normal echo setting. This only really
@@ -496,7 +489,6 @@ typedef struct ChardevClass {
int (*set_msgfds)(Chardev *s, int *fds, int num);
int (*chr_add_client)(Chardev *chr, int fd);
int (*chr_wait_connected)(Chardev *chr, Error **errp);
- void (*chr_free)(Chardev *chr);
void (*chr_disconnect)(Chardev *chr);
void (*chr_accept_input)(Chardev *chr);
void (*chr_set_echo)(Chardev *chr, bool echo);
diff --git a/qemu-char.c b/qemu-char.c
index 3d0d690999..c239418c25 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -4371,18 +4371,10 @@ void qemu_chr_fe_disconnect(CharBackend *be)
}
}
-void qemu_chr_free(Chardev *chr)
-{
- if (CHARDEV_GET_CLASS(chr)->chr_free) {
- CHARDEV_GET_CLASS(chr)->chr_free(chr);
- }
- object_unref(OBJECT(chr));
-}
-
void qemu_chr_delete(Chardev *chr)
{
QTAILQ_REMOVE(&chardevs, chr, next);
- qemu_chr_free(chr);
+ object_unref(OBJECT(chr));
}
ChardevInfoList *qmp_query_chardev(Error **errp)
--
2.11.0.295.gd7dffce1c.dirty
next prev parent reply other threads:[~2017-01-30 13:41 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 13:39 [Qemu-devel] [PATCH v2 00/41] chardev: qom clean-up and split in various backend files Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 01/41] MAINTAINERS: add myself to qemu-char.c Marc-André Lureau
2017-01-30 19:33 ` Paolo Bonzini
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 02/41] spice-qemu-char: convert to finalize Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 03/41] baum: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 04/41] msmouse: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 05/41] mux: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 06/41] char-udp: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 07/41] char-socket: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 08/41] char-pty: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 09/41] char-ringbuf: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 10/41] char-parallel: convert parallel " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 11/41] char-stdio: convert " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 12/41] char-win-stdio: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 13/41] char-win: do not override chr_free Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 14/41] char-win: convert to finalize Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 15/41] char-fd: " Marc-André Lureau
2017-01-30 13:39 ` Marc-André Lureau [this message]
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 17/41] char: get rid of CharDriver Marc-André Lureau
2017-01-30 19:50 ` Eric Blake
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 18/41] char: rename remaining CharDriver to Chardev Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 19/41] char: remove class kind field Marc-André Lureau
2017-01-30 19:57 ` Eric Blake
2017-01-30 20:06 ` Paolo Bonzini
2017-01-31 9:08 ` Marc-André Lureau
2017-01-31 11:23 ` Marc-André Lureau
2017-01-31 15:32 ` Paolo Bonzini
2017-01-31 15:32 ` Paolo Bonzini
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 20/41] char: move to chardev/ Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 21/41] char: create chardev-obj-y Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 22/41] char: make null_chr_write() the default method Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 23/41] char: move null chardev to its own file Marc-André Lureau
2017-01-30 19:58 ` Eric Blake
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 24/41] char: move mux " Marc-André Lureau
2017-01-30 20:04 ` Eric Blake
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 25/41] char: move ringbuf/memory " Marc-André Lureau
2017-01-30 20:04 ` Eric Blake
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 26/41] char: rename and move to header CHR_READ_BUF_LEN Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 27/41] char: remove unused READ_RETRIES Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 28/41] char: move QIOChannel-related stuff to char-io.h Marc-André Lureau
2017-01-30 20:07 ` Eric Blake
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 29/41] char: move fd chardev in its own file Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 30/41] char: move win chardev base class " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 31/41] char: move win-stdio into " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 32/41] char: move socket chardev to " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 33/41] char: move udp chardev in " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 34/41] char: move file " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 35/41] char: move stdio " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 36/41] char: move console " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 37/41] char: move pipe chardev " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 38/41] char: move pty " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 39/41] char: move serial chardev to " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 40/41] char: move parallel chardev in " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 41/41] char: headers clean-up Marc-André Lureau
2017-01-30 14:43 ` [Qemu-devel] [PATCH v2 00/41] chardev: qom clean-up and split in various backend files no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130133954.31353-17-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).