From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, eblake@redhat.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH v2 26/41] char: rename and move to header CHR_READ_BUF_LEN
Date: Mon, 30 Jan 2017 17:39:39 +0400 [thread overview]
Message-ID: <20170130133954.31353-27-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20170130133954.31353-1-marcandre.lureau@redhat.com>
This define is used by several character devices, place it in char
common header.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
include/sysemu/char.h | 1 +
chardev/char.c | 13 ++++++-------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/sysemu/char.h b/include/sysemu/char.h
index 1e1f5c7b2b..1a65798e3e 100644
--- a/include/sysemu/char.h
+++ b/include/sysemu/char.h
@@ -22,6 +22,7 @@ typedef enum {
CHR_EVENT_CLOSED /* connection closed */
} QEMUChrEvent;
+#define CHR_READ_BUF_LEN 4096
#define CHR_IOCTL_SERIAL_SET_PARAMS 1
typedef struct {
diff --git a/chardev/char.c b/chardev/char.c
index 6b505c6f7d..6d0d5e722b 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -87,7 +87,6 @@
#include "char-mux.h"
-#define READ_BUF_LEN 4096
#define READ_RETRIES 10
#define TCP_MAX_FDS 16
@@ -471,7 +470,7 @@ void qemu_chr_fe_accept_input(CharBackend *be)
void qemu_chr_fe_printf(CharBackend *be, const char *fmt, ...)
{
- char buf[READ_BUF_LEN];
+ char buf[CHR_READ_BUF_LEN];
va_list ap;
va_start(ap, fmt);
vsnprintf(buf, sizeof(buf), fmt, ap);
@@ -913,7 +912,7 @@ static gboolean fd_chr_read(QIOChannel *chan, GIOCondition cond, void *opaque)
Chardev *chr = CHARDEV(opaque);
FDChardev *s = FD_CHARDEV(opaque);
int len;
- uint8_t buf[READ_BUF_LEN];
+ uint8_t buf[CHR_READ_BUF_LEN];
ssize_t ret;
len = sizeof(buf);
@@ -1265,7 +1264,7 @@ static gboolean pty_chr_read(QIOChannel *chan, GIOCondition cond, void *opaque)
Chardev *chr = CHARDEV(opaque);
PtyChardev *s = PTY_CHARDEV(opaque);
gsize len;
- uint8_t buf[READ_BUF_LEN];
+ uint8_t buf[CHR_READ_BUF_LEN];
ssize_t ret;
len = sizeof(buf);
@@ -1952,7 +1951,7 @@ static void win_chr_readfile(Chardev *chr)
WinChardev *s = WIN_CHARDEV(chr);
int ret, err;
- uint8_t buf[READ_BUF_LEN];
+ uint8_t buf[CHR_READ_BUF_LEN];
DWORD size;
ZeroMemory(&s->orecv, sizeof(s->orecv));
@@ -2354,7 +2353,7 @@ err1:
typedef struct {
Chardev parent;
QIOChannel *ioc;
- uint8_t buf[READ_BUF_LEN];
+ uint8_t buf[CHR_READ_BUF_LEN];
int bufcnt;
int bufptr;
int max_size;
@@ -2759,7 +2758,7 @@ static gboolean tcp_chr_read(QIOChannel *chan, GIOCondition cond, void *opaque)
{
Chardev *chr = CHARDEV(opaque);
SocketChardev *s = SOCKET_CHARDEV(opaque);
- uint8_t buf[READ_BUF_LEN];
+ uint8_t buf[CHR_READ_BUF_LEN];
int len, size;
if (!s->connected || s->max_size <= 0) {
--
2.11.0.295.gd7dffce1c.dirty
next prev parent reply other threads:[~2017-01-30 13:42 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 13:39 [Qemu-devel] [PATCH v2 00/41] chardev: qom clean-up and split in various backend files Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 01/41] MAINTAINERS: add myself to qemu-char.c Marc-André Lureau
2017-01-30 19:33 ` Paolo Bonzini
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 02/41] spice-qemu-char: convert to finalize Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 03/41] baum: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 04/41] msmouse: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 05/41] mux: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 06/41] char-udp: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 07/41] char-socket: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 08/41] char-pty: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 09/41] char-ringbuf: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 10/41] char-parallel: convert parallel " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 11/41] char-stdio: convert " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 12/41] char-win-stdio: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 13/41] char-win: do not override chr_free Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 14/41] char-win: convert to finalize Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 15/41] char-fd: " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 16/41] char: remove chr_free Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 17/41] char: get rid of CharDriver Marc-André Lureau
2017-01-30 19:50 ` Eric Blake
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 18/41] char: rename remaining CharDriver to Chardev Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 19/41] char: remove class kind field Marc-André Lureau
2017-01-30 19:57 ` Eric Blake
2017-01-30 20:06 ` Paolo Bonzini
2017-01-31 9:08 ` Marc-André Lureau
2017-01-31 11:23 ` Marc-André Lureau
2017-01-31 15:32 ` Paolo Bonzini
2017-01-31 15:32 ` Paolo Bonzini
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 20/41] char: move to chardev/ Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 21/41] char: create chardev-obj-y Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 22/41] char: make null_chr_write() the default method Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 23/41] char: move null chardev to its own file Marc-André Lureau
2017-01-30 19:58 ` Eric Blake
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 24/41] char: move mux " Marc-André Lureau
2017-01-30 20:04 ` Eric Blake
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 25/41] char: move ringbuf/memory " Marc-André Lureau
2017-01-30 20:04 ` Eric Blake
2017-01-30 13:39 ` Marc-André Lureau [this message]
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 27/41] char: remove unused READ_RETRIES Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 28/41] char: move QIOChannel-related stuff to char-io.h Marc-André Lureau
2017-01-30 20:07 ` Eric Blake
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 29/41] char: move fd chardev in its own file Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 30/41] char: move win chardev base class " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 31/41] char: move win-stdio into " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 32/41] char: move socket chardev to " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 33/41] char: move udp chardev in " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 34/41] char: move file " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 35/41] char: move stdio " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 36/41] char: move console " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 37/41] char: move pipe chardev " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 38/41] char: move pty " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 39/41] char: move serial chardev to " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 40/41] char: move parallel chardev in " Marc-André Lureau
2017-01-30 13:39 ` [Qemu-devel] [PATCH v2 41/41] char: headers clean-up Marc-André Lureau
2017-01-30 14:43 ` [Qemu-devel] [PATCH v2 00/41] chardev: qom clean-up and split in various backend files no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130133954.31353-27-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).