From: Stefan Hajnoczi <stefanha@gmail.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 2/5] checkpatch: check utf-8 content from a commit log when it's missing from charset
Date: Mon, 30 Jan 2017 14:13:20 +0000 [thread overview]
Message-ID: <20170130141320.GF2118@stefanha-x1.localdomain> (raw)
In-Reply-To: <1485436265-12573-3-git-send-email-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]
On Thu, Jan 26, 2017 at 02:11:02PM +0100, Thomas Huth wrote:
> This is a port of the following commit from the Linux kernel:
>
> commit fa64205df9dfd7b7662cc64a7e82115c00e428e5
> Author: Pasi Savanainen <pasi.savanainen@nixu.com>
> Date: Thu Oct 4 17:13:29 2012 -0700
>
> checkpatch: check utf-8 content from a commit log when it's missing from charset
>
> Check that a commit log doesn't contain UTF-8 when a mail header
> explicitly defines a different charset, like
>
> 'Content-Type: text/plain; charset="us-ascii"'
>
> Signed-off-by: Pasi Savanainen <pasi.savanainen@nixu.com>
> Cc: Joe Perches <joe@perches.com>
> Cc: Andy Whitcroft <apw@canonical.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>
> Note: I slightly updated the regex for the "Content-Type" line check
> since most of the time, the character set does not seem to be given
> in quotes.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> scripts/checkpatch.pl | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-01-30 14:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 13:11 [Qemu-devel] [RFC PATCH 0/5] checkpatch: Test bad UTF-8 encodings and updates to MAINTAINERS Thomas Huth
2017-01-26 13:11 ` [Qemu-devel] [RFC PATCH 1/5] checkpatch: add a check for utf-8 in commit logs Thomas Huth
2017-01-30 14:12 ` Stefan Hajnoczi
2017-01-30 15:57 ` Thomas Huth
2017-02-01 16:27 ` Stefan Hajnoczi
2017-01-26 13:11 ` [Qemu-devel] [RFC PATCH 2/5] checkpatch: check utf-8 content from a commit log when it's missing from charset Thomas Huth
2017-01-30 14:13 ` Stefan Hajnoczi [this message]
2017-01-26 13:11 ` [Qemu-devel] [RFC PATCH 3/5] checkpatch: ignore email headers better Thomas Huth
2017-01-30 14:14 ` Stefan Hajnoczi
2017-01-26 13:11 ` [Qemu-devel] [RFC PATCH 4/5] checkpatch: emit a reminder about MAINTAINERS on file add/move/delete Thomas Huth
2017-01-30 14:15 ` Stefan Hajnoczi
2017-01-26 13:11 ` [Qemu-devel] [RFC PATCH 5/5] checkpatch: reduce MAINTAINERS update message frequency Thomas Huth
2017-01-26 13:28 ` Paolo Bonzini
2017-01-26 13:39 ` Thomas Huth
2017-01-26 14:03 ` Cornelia Huck
2017-01-30 14:15 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130141320.GF2118@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).