qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 41/41] char: headers clean-up
Date: Tue, 31 Jan 2017 20:21:22 +0400	[thread overview]
Message-ID: <20170131162122.29408-42-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20170131162122.29408-1-marcandre.lureau@redhat.com>

Those could probably be squashed with earlier patches, however I
couldn't easily identify them, test them or check if there are still
necessary on various platforms.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 include/sysemu/char.h   |  5 -----
 chardev/char.c          | 40 +---------------------------------------
 hmp.c                   |  1 +
 monitor.c               |  1 +
 qmp.c                   |  1 +
 tests/vhost-user-test.c |  1 +
 6 files changed, 5 insertions(+), 44 deletions(-)

diff --git a/include/sysemu/char.h b/include/sysemu/char.h
index b256e79c31..450881d42c 100644
--- a/include/sysemu/char.h
+++ b/include/sysemu/char.h
@@ -2,12 +2,7 @@
 #define QEMU_CHAR_H
 
 #include "qemu-common.h"
-#include "qemu/queue.h"
 #include "qemu/option.h"
-#include "qemu/config-file.h"
-#include "block/aio.h"
-#include "qapi/qmp/qobject.h"
-#include "qapi/qmp/qstring.h"
 #include "qemu/main-loop.h"
 #include "qemu/bitmap.h"
 #include "qom/object.h"
diff --git a/chardev/char.c b/chardev/char.c
index a9daf9956c..abd525f75e 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -26,54 +26,16 @@
 #include "qemu/cutils.h"
 #include "monitor/monitor.h"
 #include "sysemu/sysemu.h"
-#include "sysemu/block-backend.h"
+#include "qemu/config-file.h"
 #include "qemu/error-report.h"
-#include "qemu/timer.h"
 #include "sysemu/char.h"
-#include "hw/usb.h"
 #include "qmp-commands.h"
-#include "qapi/clone-visitor.h"
 #include "qapi-visit.h"
-#include "qemu/base64.h"
-#include "io/channel-socket.h"
-#include "io/channel-tls.h"
 #include "sysemu/replay.h"
 #include "qemu/help_option.h"
 
-#include <zlib.h>
-
-#ifndef _WIN32
-#include <sys/times.h>
-#include <sys/wait.h>
-#include <sys/ioctl.h>
-#include <sys/resource.h>
-#include <sys/socket.h>
-#include <netinet/in.h>
-#include <net/if.h>
-#include <arpa/inet.h>
-#include <netdb.h>
-#include <sys/select.h>
-#ifdef __sun__
-#include <sys/ethernet.h>
-#include <sys/sockio.h>
-#include <netinet/arp.h>
-#include <netinet/in.h>
-#include <netinet/in_systm.h>
-#include <netinet/ip.h>
-#include <netinet/ip_icmp.h> // must come after ip.h
-#include <netinet/udp.h>
-#include <netinet/tcp.h>
-#endif
-#endif
-
-#include "qemu/sockets.h"
-#include "ui/qemu-spice.h"
-
 #include "char-mux.h"
 #include "char-io.h"
-#ifdef _WIN32
-#include "char-win.h"
-#endif
 #include "char-parallel.h"
 #include "char-serial.h"
 
diff --git a/hmp.c b/hmp.c
index 8522efea26..2bc4f062bb 100644
--- a/hmp.c
+++ b/hmp.c
@@ -19,6 +19,7 @@
 #include "net/eth.h"
 #include "sysemu/char.h"
 #include "sysemu/block-backend.h"
+#include "qemu/config-file.h"
 #include "qemu/option.h"
 #include "qemu/timer.h"
 #include "qmp-commands.h"
diff --git a/monitor.c b/monitor.c
index 25a480a95e..b0181cb0e6 100644
--- a/monitor.c
+++ b/monitor.c
@@ -40,6 +40,7 @@
 #include "sysemu/sysemu.h"
 #include "sysemu/numa.h"
 #include "monitor/monitor.h"
+#include "qemu/config-file.h"
 #include "qemu/readline.h"
 #include "ui/console.h"
 #include "ui/input.h"
diff --git a/qmp.c b/qmp.c
index 2834f02b69..dfaabac1a6 100644
--- a/qmp.c
+++ b/qmp.c
@@ -18,6 +18,7 @@
 #include "qemu/cutils.h"
 #include "monitor/monitor.h"
 #include "sysemu/sysemu.h"
+#include "qemu/config-file.h"
 #include "qemu/uuid.h"
 #include "qmp-commands.h"
 #include "sysemu/char.h"
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index f3ac6ea21a..2c45c7b29f 100644
--- a/tests/vhost-user-test.c
+++ b/tests/vhost-user-test.c
@@ -12,6 +12,7 @@
 
 #include "libqtest.h"
 #include "qapi/error.h"
+#include "qemu/config-file.h"
 #include "qemu/option.h"
 #include "qemu/range.h"
 #include "qemu/sockets.h"
-- 
2.11.0.295.gd7dffce1c.dirty

  parent reply	other threads:[~2017-01-31 16:24 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-31 16:20 [Qemu-devel] [PULL 00/41] Chr split patches Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 01/41] MAINTAINERS: add myself to qemu-char.c Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 02/41] spice-qemu-char: convert to finalize Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 03/41] baum: " Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 04/41] msmouse: " Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 05/41] mux: " Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 06/41] char-udp: " Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 07/41] char-socket: " Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 08/41] char-pty: " Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 09/41] char-ringbuf: " Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 10/41] char-parallel: convert parallel " Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 11/41] char-stdio: convert " Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 12/41] char-win-stdio: " Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 13/41] char-win: do not override chr_free Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 14/41] char-win: convert to finalize Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 15/41] char-fd: " Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 16/41] char: remove chr_free Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 17/41] char: get rid of CharDriver Marc-André Lureau
2017-01-31 16:20 ` [Qemu-devel] [PULL 18/41] char: rename remaining CharDriver to Chardev Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 19/41] char: remove class kind field Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 20/41] char: move to chardev/ Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 21/41] char: create chardev-obj-y Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 22/41] char: make null_chr_write() the default method Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 23/41] char: move null chardev to its own file Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 24/41] char: move mux " Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 25/41] char: move ringbuf/memory " Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 26/41] char: rename and move to header CHR_READ_BUF_LEN Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 27/41] char: remove unused READ_RETRIES Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 28/41] char: move QIOChannel-related stuff to char-io.h Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 29/41] char: move fd chardev in its own file Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 30/41] char: move win chardev base class " Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 31/41] char: move win-stdio into " Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 32/41] char: move socket chardev to " Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 33/41] char: move udp chardev in " Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 34/41] char: move file " Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 35/41] char: move stdio " Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 36/41] char: move console " Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 37/41] char: move pipe chardev " Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 38/41] char: move pty " Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 39/41] char: move serial chardev to " Marc-André Lureau
2017-01-31 16:21 ` [Qemu-devel] [PULL 40/41] char: move parallel chardev in " Marc-André Lureau
2017-01-31 16:21 ` Marc-André Lureau [this message]
2017-01-31 17:57 ` [Qemu-devel] [PULL 00/41] Chr split patches no-reply
2017-01-31 18:41 ` Peter Maydell
2017-01-31 18:55   ` Marc-André Lureau
2017-01-31 19:00     ` Eric Blake
2017-01-31 19:37       ` Marc-André Lureau
2017-01-31 20:02         ` Peter Maydell
2017-02-02 11:03         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170131162122.29408-42-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).