qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL 09/10] qapi: add missing trace_visit_type_enum() call
Date: Wed,  1 Feb 2017 13:44:52 +0000	[thread overview]
Message-ID: <20170201134453.11963-10-stefanha@redhat.com> (raw)
In-Reply-To: <20170201134453.11963-1-stefanha@redhat.com>

A trace event exists for enums but it's never called.  This patch fixes
this oversight so that enums are traced just like the other QAPI types.

Suggested-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20170126171613.1399-2-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 qapi/qapi-visit-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c
index 63bd97b..e6e93f0 100644
--- a/qapi/qapi-visit-core.c
+++ b/qapi/qapi-visit-core.c
@@ -374,6 +374,7 @@ void visit_type_enum(Visitor *v, const char *name, int *obj,
                      const char *const strings[], Error **errp)
 {
     assert(obj && strings);
+    trace_visit_type_enum(v, name, obj);
     switch (v->type) {
     case VISITOR_INPUT:
         input_type_enum(v, name, obj, strings, errp);
-- 
2.9.3

  parent reply	other threads:[~2017-02-01 13:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 13:44 [Qemu-devel] [PULL 00/10] Tracing patches Stefan Hajnoczi
2017-02-01 13:44 ` [Qemu-devel] [PULL 01/10] make: move top level dir to end of include search path Stefan Hajnoczi
2017-02-01 13:44 ` [Qemu-devel] [PULL 02/10] trace: move hw/block/dataplane events to correct subdir Stefan Hajnoczi
2017-02-01 13:44 ` [Qemu-devel] [PULL 03/10] trace: move hw/xen " Stefan Hajnoczi
2017-02-01 13:44 ` [Qemu-devel] [PULL 04/10] trace: move hw/i386/xen " Stefan Hajnoczi
2017-02-01 13:44 ` [Qemu-devel] [PULL 05/10] trace: move setting of group name into Makefiles Stefan Hajnoczi
2017-02-01 13:44 ` [Qemu-devel] [PULL 06/10] trace: switch to modular code generation for sub-directories Stefan Hajnoczi
2017-02-01 13:44 ` [Qemu-devel] [PULL 07/10] trace: update docs to reflect new code generation approach Stefan Hajnoczi
2017-02-01 13:44 ` [Qemu-devel] [PULL 08/10] trace: improve error reporting when parsing simpletrace header Stefan Hajnoczi
2017-02-01 13:44 ` Stefan Hajnoczi [this message]
2017-02-01 13:44 ` [Qemu-devel] [PULL 10/10] trace: clean up trace-events files Stefan Hajnoczi
2017-02-02 18:47 ` [Qemu-devel] [PULL 00/10] Tracing patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170201134453.11963-10-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).