From: "Alex Bennée" <alex.bennee@linaro.org>
To: mttcg@listserver.greensocs.com, qemu-devel@nongnu.org,
fred.konrad@greensocs.com, a.rigo@virtualopensystems.com,
cota@braap.org, bobby.prani@gmail.com, nikunj@linux.vnet.ibm.com
Cc: mark.burton@greensocs.com, pbonzini@redhat.com,
jan.kiszka@siemens.com, serge.fdrv@gmail.com, rth@twiddle.net,
peter.maydell@linaro.org, bamvor.zhangjian@linaro.org,
"Alex Bennée" <alex.bennee@linaro.org>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>
Subject: [Qemu-devel] [PATCH v9 12/25] tcg: handle EXCP_ATOMIC exception for system emulation
Date: Wed, 1 Feb 2017 15:05:40 +0000 [thread overview]
Message-ID: <20170201150553.9381-13-alex.bennee@linaro.org> (raw)
In-Reply-To: <20170201150553.9381-1-alex.bennee@linaro.org>
From: Pranith Kumar <bobby.prani@gmail.com>
The patch enables handling atomic code in the guest. This should be
preferably done in cpu_handle_exception(), but the current assumptions
regarding when we can execute atomic sections cause a deadlock.
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
[AJB: tweak title]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
---
cpus.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/cpus.c b/cpus.c
index ecd1ec08d3..e3d9f3fe21 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1346,6 +1346,11 @@ static void *qemu_tcg_rr_cpu_thread_fn(void *arg)
if (r == EXCP_DEBUG) {
cpu_handle_guest_debug(cpu);
break;
+ } else if (r == EXCP_ATOMIC) {
+ qemu_mutex_unlock_iothread();
+ cpu_exec_step_atomic(cpu);
+ qemu_mutex_lock_iothread();
+ break;
}
} else if (cpu->stop) {
if (cpu->unplug) {
@@ -1456,6 +1461,10 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
*/
g_assert(cpu->halted);
break;
+ case EXCP_ATOMIC:
+ qemu_mutex_unlock_iothread();
+ cpu_exec_step_atomic(cpu);
+ qemu_mutex_lock_iothread();
default:
/* Ignore everything else? */
break;
--
2.11.0
next prev parent reply other threads:[~2017-02-01 15:06 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 15:05 [Qemu-devel] [PATCH v9 00/25] MTTCG Base enabling patches with ARM enablement Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 01/25] docs: new design document multi-thread-tcg.txt Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 02/25] mttcg: translate-all: Enable locking debug in a debug build Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 03/25] mttcg: Add missing tb_lock/unlock() in cpu_exec_step() Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 04/25] tcg: move TCG_MO/BAR types into own file Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 05/25] tcg: add options for enabling MTTCG Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 06/25] tcg: add kick timer for single-threaded vCPU emulation Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 07/25] tcg: rename tcg_current_cpu to tcg_current_rr_cpu Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 08/25] tcg: drop global lock during TCG code execution Alex Bennée
2017-02-03 10:09 ` Peter Maydell
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 09/25] tcg: remove global exit_request Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 10/25] tcg: enable tb_lock() for SoftMMU Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 11/25] tcg: enable thread-per-vCPU Alex Bennée
2017-02-01 15:05 ` Alex Bennée [this message]
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 13/25] cputlb: add assert_cpu_is_self checks Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 14/25] cputlb: tweak qemu_ram_addr_from_host_nofail reporting Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 15/25] cputlb: introduce tlb_flush_* async work Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 16/25] cputlb and arm/sparc targets: convert mmuidx flushes from varg to bitmap Alex Bennée
2017-02-01 21:29 ` Richard Henderson
2017-02-03 10:15 ` Peter Maydell
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 17/25] cputlb: add tlb_flush_by_mmuidx async routines Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 18/25] cputlb: atomically update tlb fields used by tlb_reset_dirty Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 19/25] cputlb: introduce tlb_flush_*_all_cpus[_synced] Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 20/25] target-arm/powerctl: defer cpu reset work to CPU context Alex Bennée
2017-02-03 11:15 ` Peter Maydell
2017-02-03 15:02 ` Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 21/25] target-arm: don't generate WFE/YIELD calls for MTTCG Alex Bennée
2017-02-03 11:17 ` Peter Maydell
2017-02-03 11:30 ` Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 22/25] target-arm/cpu.h: make ARM_CP defined consistent Alex Bennée
2017-02-03 11:19 ` Peter Maydell
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 23/25] target-arm: introduce ARM_CP_EXIT_PC Alex Bennée
2017-02-03 11:22 ` Peter Maydell
2017-02-03 11:33 ` Alex Bennée
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 24/25] target-arm: ensure all cross vCPUs TLB flushes complete Alex Bennée
2017-02-03 11:33 ` Peter Maydell
2017-02-01 15:05 ` [Qemu-devel] [PATCH v9 25/25] tcg: enable MTTCG by default for ARM on x86 hosts Alex Bennée
2017-02-03 11:25 ` Peter Maydell
2017-02-03 12:07 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201150553.9381-13-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=a.rigo@virtualopensystems.com \
--cc=bamvor.zhangjian@linaro.org \
--cc=bobby.prani@gmail.com \
--cc=cota@braap.org \
--cc=crosthwaite.peter@gmail.com \
--cc=fred.konrad@greensocs.com \
--cc=jan.kiszka@siemens.com \
--cc=mark.burton@greensocs.com \
--cc=mttcg@listserver.greensocs.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=serge.fdrv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).