From: "Daniel P. Berrange" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org,
Anton Nefedov <anton.nefedov@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] qemu_char: socket backend: disconnect on EPIPE
Date: Thu, 2 Feb 2017 09:49:18 +0000 [thread overview]
Message-ID: <20170202094918.GB2915@redhat.com> (raw)
In-Reply-To: <f9e50c49-4a25-ad69-0317-08e99b8fada1@redhat.com>
On Wed, Feb 01, 2017 at 04:54:28PM -0800, Paolo Bonzini wrote:
>
>
> On 01/02/2017 05:53, Daniel P. Berrange wrote:
> >>
> >> + if (ret < 0 && errno == EPIPE) {
> > IMHO you should just remove "&& errno == EPIPE" and it'd be fine.
>
> It should be errno != EAGAIN.
Oh, yes, thats right.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2017-02-02 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 13:15 [Qemu-devel] [PATCH 1/1] qemu_char: socket backend: disconnect on EPIPE Denis V. Lunev
2017-02-01 13:53 ` Daniel P. Berrange
2017-02-02 0:54 ` Paolo Bonzini
2017-02-02 9:49 ` Daniel P. Berrange [this message]
2017-02-02 8:59 ` Denis V. Lunev
2017-02-02 9:47 ` Daniel P. Berrange
2017-02-02 11:43 ` Denis V. Lunev
2017-02-02 11:46 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202094918.GB2915@redhat.com \
--to=berrange@redhat.com \
--cc=anton.nefedov@virtuozzo.com \
--cc=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).