From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZE4o-0004Ip-My for qemu-devel@nongnu.org; Thu, 02 Feb 2017 04:53:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZE4n-00089P-O4 for qemu-devel@nongnu.org; Thu, 02 Feb 2017 04:53:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40156) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cZE4n-00088w-I9 for qemu-devel@nongnu.org; Thu, 02 Feb 2017 04:53:13 -0500 Date: Thu, 2 Feb 2017 09:53:02 +0000 From: "Daniel P. Berrange" Message-ID: <20170202095302.GC2915@redhat.com> Reply-To: "Daniel P. Berrange" References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ketan Nilangekar Cc: Stefan Hajnoczi , Buddhi Madhav , ashish mittal , Paolo Bonzini , Jeff Cody , qemu-devel , Kevin Wolf , Markus Armbruster , Fam Zheng , Ashish Mittal , Abhijit Dey , "Venkatesha M.G." , Nitin Jerath , Gaurav Bhandarkar , Abhishek Kane , Ketan Mahajan , Niranjan Pendharkar , Nirendra Awasthi , Rakesh Ranjan On Wed, Feb 01, 2017 at 11:59:53PM +0000, Ketan Nilangekar wrote: > Patch for secure implementation in libqnio is available for review here: > > https://github.com/VeritasHyperScale/libqnio/pull/12 IMHO, we really don't want libqnio to be doing the SSL handling itself. QEMU has a standardized API for doing SSL that the vxhs layer should be using, so that its behaviour & configuration is exactly the same as other bits of QEMU using SSL. To do this, libqnio would have to delegate all socket I/O to QEMU, by providing a set of callback APIs that QEMU can provide implementations for. The QEMU block driver for vxhs would use qio_channel_socket and qio_channel_tls APIs to setup the socket & do SSL handshakes, etc. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|