From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
keith.busch@intel.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] nvme: implement the DSM command
Date: Thu, 2 Feb 2017 10:17:58 +0000 [thread overview]
Message-ID: <20170202101758.GC22164@stefanha-x1.localdomain> (raw)
In-Reply-To: <af5d7115-1b30-41aa-f3e5-0c4e4271d52c@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
On Wed, Feb 01, 2017 at 12:29:22PM -0800, Paolo Bonzini wrote:
> On 01/02/2017 08:40, Stefan Hajnoczi wrote:
> >> + goto out_free_range;
> >> + }
> >> +
> >> + if (dma_buf_write((uint8_t *)range, sizeof(range), &qsg)) {
> >
> > Did you mean sizeof(*range) * nr?
>
> Did you also mean dma_buf_read (you want to read from device to range)?
uint64_t dma_buf_write(uint8_t *ptr, int32_t len, QEMUSGList *sg)
{
return dma_buf_rw(ptr, len, sg, DMA_DIRECTION_TO_DEVICE);
}
DMA_DIRECTION_TO_DEVICE seems correct.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-02-02 10:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 18:13 [Qemu-devel] [PATCH 0/2] two more NVMe commands Christoph Hellwig
2017-01-30 18:13 ` [Qemu-devel] [PATCH 1/2] nvme: implement the DSM command Christoph Hellwig
2017-01-30 18:55 ` Keith Busch
2017-02-01 16:40 ` Stefan Hajnoczi
2017-02-01 20:29 ` Paolo Bonzini
2017-02-02 10:17 ` Stefan Hajnoczi [this message]
2017-02-02 12:04 ` Paolo Bonzini
2017-01-30 18:13 ` [Qemu-devel] [PATCH 2/2] nvme: Implement Write Zeroes Christoph Hellwig
2017-02-01 16:41 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202101758.GC22164@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).