Re: [Qemu-devel] [RFC 4/4] hw/intc/arm_gicv3_its: Allow save/restore

[Peter Xu <peterx@redhat.com>]

On Thu, Jan 26, 2017 at 02:30:17PM +0100, Auger Eric wrote:

[...]

> >> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> >> index 1a22887..ebd755c 100644
> >> --- a/include/migration/vmstate.h
> >> +++ b/include/migration/vmstate.h
> >> @@ -188,6 +188,8 @@ enum VMStateFlags {
> >>  
> >>  typedef enum {
> >>      MIG_PRI_DEFAULT = 0,
> >> +    MIG_PRI_GICV3_ITS,
> >> +    MIG_PRI_GICV3,
> >>      MIG_PRI_MAX,
> > 
> > Can we keep this commented so it's trivially easy to see the order, something like:
> > 
> >  typedef enum {
> >      MIG_PRI_DEFAULT = 0,
> > +    MIG_PRI_GICV3_ITS,    /* Needs to be before PCI devices */
> > +    MIG_PRI_GICV3,        /* Must be before ITS */
> Sure
> 
> Thanks!

Besides above: is it possible that in the future other platforms
(rather than ARM) can leverage these new introduced priority? If so,
would it be nicer that we use general names (like, e.g., INTCxxx? or
better?) rather than platform-specific names (like, GICxxx)?

Thanks,

-- peterx