From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH] configure: remove --enable-replication/--disable-replication
Date: Fri, 3 Feb 2017 15:00:50 +0000 [thread overview]
Message-ID: <20170203150050.GF642@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170202150530.1025-1-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
On Thu, Feb 02, 2017 at 07:05:30AM -0800, Paolo Bonzini wrote:
> The replication feature is a small amount of code, does not
> require any external library and unless used does not add
> anything to the guest's attack surface. Since any extra
> configure option affects maintainability on the other hand
> and is subject to bit rot, I think there is no need to
> make it configurable.
I think the current state is good: replication is enabled by default but
can be compiled out if desired.
Downstreams may not be comfortable supporting this feature yet since
it's incomplete. It's fair to offer an option to disable it, otherwise
downstreams will have to patch this themselves.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-02-03 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 15:05 [Qemu-devel] [RFC PATCH] configure: remove --enable-replication/--disable-replication Paolo Bonzini
2017-02-02 15:15 ` Dr. David Alan Gilbert
2017-02-03 15:00 ` Stefan Hajnoczi [this message]
2017-02-03 17:08 ` Paolo Bonzini
2017-02-06 11:57 ` Dr. David Alan Gilbert
2017-03-03 20:34 ` Bruce Rogers
2017-03-03 21:26 ` Paolo Bonzini
2017-03-06 9:08 ` Dr. David Alan Gilbert
2017-03-06 10:03 ` Zhang Chen
2017-03-06 12:54 ` Paolo Bonzini
2017-03-07 3:50 ` Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203150050.GF642@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).