From: "Daniel P. Berrange" <berrange@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all"
Date: Mon, 6 Feb 2017 10:35:39 +0000 [thread overview]
Message-ID: <20170206103538.GE3029@redhat.com> (raw)
In-Reply-To: <20170204143245.15974-1-famz@redhat.com>
On Sat, Feb 04, 2017 at 10:32:45PM +0800, Fam Zheng wrote:
> We install this file to data dir but since 0ab8ed18 it's no longer
> required by any objects during "make". List it explicitly as a depended
> target of install and fix the broken "make install" command.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2017-02-06 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 14:32 [Qemu-devel] [PATCH] Makefile: Make "install" depend on "trace-events-all" Fam Zheng
2017-02-04 22:39 ` Lluís Vilanova
2017-02-06 10:36 ` Daniel P. Berrange
2017-02-06 10:35 ` Daniel P. Berrange [this message]
2017-02-07 10:17 ` Christian Borntraeger
2017-02-07 15:14 ` Stefan Hajnoczi
2017-02-07 22:25 ` Doug Gilmore
2017-02-13 14:04 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206103538.GE3029@redhat.com \
--to=berrange@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).