qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Pavel Butsykin <pbutsykin@virtuozzo.com>
Cc: den@virtuozzo.com, armbru@redhat.com, qemu-devel@nongnu.org,
	quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration: madvise error_report fixup!
Date: Fri, 10 Feb 2017 14:47:34 +0000	[thread overview]
Message-ID: <20170210144733.GG2568@work-vm> (raw)
In-Reply-To: <20170210143651.24046-1-pbutsykin@virtuozzo.com>

* Pavel Butsykin (pbutsykin@virtuozzo.com) wrote:
> Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

I'll merge it in with the others when I queue it.

Dave

> ---
>  migration/qemu-file.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/migration/qemu-file.c b/migration/qemu-file.c
> index 82dbef3c86..195fa94fcf 100644
> --- a/migration/qemu-file.c
> +++ b/migration/qemu-file.c
> @@ -156,13 +156,13 @@ static void qemu_iovec_release_ram(QEMUFile *f)
>              continue;
>          }
>          if (qemu_madvise(iov.iov_base, iov.iov_len, QEMU_MADV_DONTNEED) < 0) {
> -            error_report("migrate: madvise DONTNEED failed %p %ld: %s",
> +            error_report("migrate: madvise DONTNEED failed %p %zd: %s",
>                           iov.iov_base, iov.iov_len, strerror(errno));
>          }
>          iov = f->iov[idx];
>      }
>      if (qemu_madvise(iov.iov_base, iov.iov_len, QEMU_MADV_DONTNEED) < 0) {
> -            error_report("migrate: madvise DONTNEED failed %p %ld: %s",
> +            error_report("migrate: madvise DONTNEED failed %p %zd: %s",
>                           iov.iov_base, iov.iov_len, strerror(errno));
>      }
>      memset(f->may_free, 0, sizeof(f->may_free));
> -- 
> 2.11.0
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  reply	other threads:[~2017-02-10 14:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-03 15:23 [Qemu-devel] [PATCH v2 0/3] migration capability to discard the migrated ram pages Pavel Butsykin
2017-02-03 15:23 ` [Qemu-devel] [PATCH v2 1/3] migration: add MigrationState arg for ram_save_/compressed_/page() Pavel Butsykin
2017-02-10 11:54   ` Dr. David Alan Gilbert
2017-02-14 23:22   ` Philippe Mathieu-Daudé
2017-02-03 15:23 ` [Qemu-devel] [PATCH v2 2/3] add 'release-ram' migrate capability Pavel Butsykin
2017-02-10 12:22   ` Dr. David Alan Gilbert
2017-02-10 12:25     ` Dr. David Alan Gilbert
2017-02-10 14:36       ` [Qemu-devel] [PATCH] migration: madvise error_report fixup! Pavel Butsykin
2017-02-10 14:47         ` Dr. David Alan Gilbert [this message]
2017-02-03 15:23 ` [Qemu-devel] [PATCH v2 3/3] migration: discard non-dirty ram pages after the start of postcopy Pavel Butsykin
2017-02-10 12:29   ` Dr. David Alan Gilbert
2017-02-03 17:07 ` [Qemu-devel] [PATCH v2 0/3] migration capability to discard the migrated ram pages no-reply
2017-02-10 15:12 ` Dr. David Alan Gilbert
2017-02-14 14:02 ` Dr. David Alan Gilbert
2017-03-03  8:39   ` Pavel Butsykin
2017-03-07 13:56     ` Dr. David Alan Gilbert
2017-03-07 14:42       ` Pavel Butsykin
2017-03-07 14:46         ` Dr. David Alan Gilbert
2017-03-07 15:16           ` Pavel Butsykin
2017-03-07 15:17             ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170210144733.GG2568@work-vm \
    --to=dgilbert@redhat.com \
    --cc=armbru@redhat.com \
    --cc=den@virtuozzo.com \
    --cc=pbutsykin@virtuozzo.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).