From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd9ZI-0001c7-C6 for qemu-devel@nongnu.org; Mon, 13 Feb 2017 00:52:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cd9ZH-0007Ww-8I for qemu-devel@nongnu.org; Mon, 13 Feb 2017 00:52:56 -0500 Date: Mon, 13 Feb 2017 13:52:46 +0800 From: Fam Zheng Message-ID: <20170213055246.GC15004@lemon.lan> References: <20170212014724.10618-1-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170212014724.10618-1-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Swap request limit definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-block@nongnu.org, Kevin Wolf , qemu-devel@nongnu.org On Sun, 02/12 02:47, Max Reitz wrote: > Defining BDRV_REQUEST_MAX_SECTORS based on BDRV_REQUEST_MAX_BYTES is > simpler than the other way around. > > Signed-off-by: Max Reitz > --- > include/block/block.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/block/block.h b/include/block/block.h > index 4e81f2069b..101ef33f6b 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -114,9 +114,8 @@ typedef struct HDGeometry { > #define BDRV_SECTOR_SIZE (1ULL << BDRV_SECTOR_BITS) > #define BDRV_SECTOR_MASK ~(BDRV_SECTOR_SIZE - 1) > > -#define BDRV_REQUEST_MAX_SECTORS MIN(SIZE_MAX >> BDRV_SECTOR_BITS, \ > - INT_MAX >> BDRV_SECTOR_BITS) > -#define BDRV_REQUEST_MAX_BYTES (BDRV_REQUEST_MAX_SECTORS << BDRV_SECTOR_BITS) > +#define BDRV_REQUEST_MAX_BYTES MIN(SIZE_MAX, INT_MAX) > +#define BDRV_REQUEST_MAX_SECTORS (BDRV_REQUEST_MAX_BYTES >> BDRV_SECTOR_BITS) > > /* > * Allocation status flags > -- > 2.11.0 > > Reviewed-by: Fam Zheng