From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdDhk-0007xA-E0 for qemu-devel@nongnu.org; Mon, 13 Feb 2017 05:18:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdDhj-0000tO-9R for qemu-devel@nongnu.org; Mon, 13 Feb 2017 05:17:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60768) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cdDhj-0000t4-3s for qemu-devel@nongnu.org; Mon, 13 Feb 2017 05:17:55 -0500 Date: Mon, 13 Feb 2017 10:17:48 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20170213101748.GB3086@work-vm> References: <1484657864-21708-1-git-send-email-zhang.zhanghailiang@huawei.com> <20170210154435.GF13357@work-vm> <58A17283.5020609@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58A17283.5020609@huawei.com> Subject: Re: [Qemu-devel] [PATCH 0/3] COLO: fix some bugs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hailiang Zhang Cc: xuquan8@huawei.com, qemu-devel@nongnu.org, quintela@redhat.com, eddie.dong@intel.com, lizhijian@cn.fujitsu.com, zhangchen.fnst@cn.fujitsu.com * Hailiang Zhang (zhang.zhanghailiang@huawei.com) wrote: > On 2017/2/10 23:44, Dr. David Alan Gilbert wrote: > > * zhanghailiang (zhang.zhanghailiang@huawei.com) wrote: > > > Hi, > > > > > > This series fix three bugs of COLO. > > > patch 1 fix one usage case which users want to change checkpoint-delay > > > with an extream big value set before, the new value may not take effect > > > until finishing a long time of sleep. > > > > > > Patch 2 and 3 are old patches that split from previous version > > > long time ago, and has been reviewed by Dave. > > > > > > I'd like to pick these three patches from the later COLO series, > > > which will include some optimization and integrating with block > > > replication and COLO net proxy. > > > > > > Please review, thanks. > > > > Queued. > > I've added the '(Since 2.9)' that Eric asked for. > > > > Thank you very much. > By the way, as we discussed in patch 1, should i add the codes in patch 1 > which kick the colo_checkpoint_sem to quick the colo thread exiting ? > In next version ? Or post a new patch ? Post a new patch sometime. Dave > Hailiang > > > > Dave > > > > > > > > > > > zhanghailiang (3): > > > COLO: fix setting checkpoint-delay not working properly > > > COLO: Shutdown related socket fd while do failover > > > COLO: Don't process failover request while loading VM's state > > > > > > include/migration/colo.h | 2 + > > > include/migration/migration.h | 8 ++++ > > > migration/colo.c | 102 +++++++++++++++++++++++++++++++++++++----- > > > migration/migration.c | 3 ++ > > > qapi-schema.json | 4 +- > > > 5 files changed, 108 insertions(+), 11 deletions(-) > > > > > > -- > > > 1.8.3.1 > > > > > > > > > > > -- > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > > > > . > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK