qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: P J P <ppandit@redhat.com>
To: Qemu Developers <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Alistair Francis <alistair23@gmail.com>,
	Wjjzhang <wjjzhang@tencent.com>, Jiang Xin <jiangxin1@huawei.com>,
	Prasad J Pandit <pjp@fedoraproject.org>
Subject: [Qemu-devel] [PATCH v4 0/4] sd: sdhci: correct transfer mode register usage
Date: Wed, 15 Feb 2017 00:22:21 +0530	[thread overview]
Message-ID: <20170214185225.7994-1-ppandit@redhat.com> (raw)

From: Prasad J Pandit <pjp@fedoraproject.org>

Hello,

In SDHCI protocol, the 'Block Count Enable' bit of the Transfer Mode
register is used to control 's->blkcnt' value. This bit is not relevant
in single block transfers. Also, Transfer Mode register value could be
set such that 's->blkcnt' would not see an update during multi block
transfers. Thus leading to an infinite loop.

This patch set attempts to correct 'Block Count Enable' bit usage.

This series incorporates changes suggested in patch set v3:
  -> https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg02376.html
  -> https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg02905.html

Thank you.
--
Prasad J Pandit (4):
  sd: sdhci: mask transfer mode register value
  sd: sdhci: check transfer mode register in multi block transfer
  sd: sdhci: conditionally invoke multi block transfer
  sd: sdhci: Remove block count enable check in single block transfers

 hw/sd/sdhci.c | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

-- 
2.9.3

             reply	other threads:[~2017-02-14 18:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 18:52 P J P [this message]
2017-02-14 18:52 ` [Qemu-devel] [PATCH v4 1/4] sd: sdhci: mask transfer mode register value P J P
2017-02-14 19:12   ` Alistair Francis
2017-02-14 18:52 ` [Qemu-devel] [PATCH v4 2/4] sd: sdhci: check transfer mode register in multi block transfer P J P
2017-02-14 19:13   ` Alistair Francis
2017-02-15  4:58     ` P J P
2017-02-17 13:10       ` Peter Maydell
2017-02-20  7:44         ` P J P
2017-02-14 18:52 ` [Qemu-devel] [PATCH v4 3/4] sd: sdhci: conditionally invoke " P J P
2017-02-14 18:52 ` [Qemu-devel] [PATCH v4 4/4] sd: sdhci: Remove block count enable check in single block transfers P J P
2017-02-17 21:54   ` Alistair Francis
2017-02-17 13:21 ` [Qemu-devel] [PATCH v4 0/4] sd: sdhci: correct transfer mode register usage Peter Maydell
2017-02-17 21:55   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170214185225.7994-1-ppandit@redhat.com \
    --to=ppandit@redhat.com \
    --cc=alistair23@gmail.com \
    --cc=jiangxin1@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=pjp@fedoraproject.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wjjzhang@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).