qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: P J P <ppandit@redhat.com>
To: Qemu Developers <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Alistair Francis <alistair23@gmail.com>,
	Wjjzhang <wjjzhang@tencent.com>, Jiang Xin <jiangxin1@huawei.com>,
	Prasad J Pandit <pjp@fedoraproject.org>
Subject: [Qemu-devel] [PATCH v4 4/4] sd: sdhci: Remove block count enable check in single block transfers
Date: Wed, 15 Feb 2017 00:22:25 +0530	[thread overview]
Message-ID: <20170214185225.7994-5-ppandit@redhat.com> (raw)
In-Reply-To: <20170214185225.7994-1-ppandit@redhat.com>

From: Prasad J Pandit <pjp@fedoraproject.org>

In SDHCI protocol, the 'Block count enable' bit of the Transfer
Mode register is relevant only in multi block transfers. We need
not check it in single block transfers.

Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
 hw/sd/sdhci.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 8ae75fe..05558d3 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -570,7 +570,6 @@ static void sdhci_sdma_transfer_multi_blocks(SDHCIState *s)
 }
 
 /* single block SDMA transfer */
-
 static void sdhci_sdma_transfer_single_block(SDHCIState *s)
 {
     int n;
@@ -589,10 +588,7 @@ static void sdhci_sdma_transfer_single_block(SDHCIState *s)
             sdbus_write_data(&s->sdbus, s->fifo_buffer[n]);
         }
     }
-
-    if (s->trnmod & SDHC_TRNS_BLK_CNT_EN) {
-        s->blkcnt--;
-    }
+    s->blkcnt--;
 
     sdhci_end_transfer(s);
 }
-- 
2.9.3

  parent reply	other threads:[~2017-02-14 18:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 18:52 [Qemu-devel] [PATCH v4 0/4] sd: sdhci: correct transfer mode register usage P J P
2017-02-14 18:52 ` [Qemu-devel] [PATCH v4 1/4] sd: sdhci: mask transfer mode register value P J P
2017-02-14 19:12   ` Alistair Francis
2017-02-14 18:52 ` [Qemu-devel] [PATCH v4 2/4] sd: sdhci: check transfer mode register in multi block transfer P J P
2017-02-14 19:13   ` Alistair Francis
2017-02-15  4:58     ` P J P
2017-02-17 13:10       ` Peter Maydell
2017-02-20  7:44         ` P J P
2017-02-14 18:52 ` [Qemu-devel] [PATCH v4 3/4] sd: sdhci: conditionally invoke " P J P
2017-02-14 18:52 ` P J P [this message]
2017-02-17 21:54   ` [Qemu-devel] [PATCH v4 4/4] sd: sdhci: Remove block count enable check in single block transfers Alistair Francis
2017-02-17 13:21 ` [Qemu-devel] [PATCH v4 0/4] sd: sdhci: correct transfer mode register usage Peter Maydell
2017-02-17 21:55   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170214185225.7994-5-ppandit@redhat.com \
    --to=ppandit@redhat.com \
    --cc=alistair23@gmail.com \
    --cc=jiangxin1@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=pjp@fedoraproject.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wjjzhang@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).