From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdiDY-0007Hw-Tl for qemu-devel@nongnu.org; Tue, 14 Feb 2017 13:52:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdiDW-0008FZ-Bg for qemu-devel@nongnu.org; Tue, 14 Feb 2017 13:52:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32884) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cdiDW-0008EY-5N for qemu-devel@nongnu.org; Tue, 14 Feb 2017 13:52:46 -0500 From: P J P Date: Wed, 15 Feb 2017 00:22:25 +0530 Message-Id: <20170214185225.7994-5-ppandit@redhat.com> In-Reply-To: <20170214185225.7994-1-ppandit@redhat.com> References: <20170214185225.7994-1-ppandit@redhat.com> Subject: [Qemu-devel] [PATCH v4 4/4] sd: sdhci: Remove block count enable check in single block transfers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Qemu Developers Cc: Peter Maydell , Alistair Francis , Wjjzhang , Jiang Xin , Prasad J Pandit From: Prasad J Pandit In SDHCI protocol, the 'Block count enable' bit of the Transfer Mode register is relevant only in multi block transfers. We need not check it in single block transfers. Signed-off-by: Prasad J Pandit --- hw/sd/sdhci.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 8ae75fe..05558d3 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -570,7 +570,6 @@ static void sdhci_sdma_transfer_multi_blocks(SDHCIState *s) } /* single block SDMA transfer */ - static void sdhci_sdma_transfer_single_block(SDHCIState *s) { int n; @@ -589,10 +588,7 @@ static void sdhci_sdma_transfer_single_block(SDHCIState *s) sdbus_write_data(&s->sdbus, s->fifo_buffer[n]); } } - - if (s->trnmod & SDHC_TRNS_BLK_CNT_EN) { - s->blkcnt--; - } + s->blkcnt--; sdhci_end_transfer(s); } -- 2.9.3