From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Juan Quintela" <quintela@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] migration: consolidate VMStateField.start
Date: Wed, 15 Feb 2017 11:46:46 +0000 [thread overview]
Message-ID: <20170215114646.GC2731@work-vm> (raw)
In-Reply-To: <34825483-e6c0-085b-bb85-4d54bad6e2b1@linux.vnet.ibm.com>
* Halil Pasic (pasic@linux.vnet.ibm.com) wrote:
>
>
> On 02/11/2017 05:26 AM, Philippe Mathieu-Daudé wrote:
> > On 02/10/2017 12:24 PM, Dr. David Alan Gilbert wrote:
> >> * Halil Pasic (pasic@linux.vnet.ibm.com) wrote:
> >>> The member VMStateField.start is used for two things, partial data
> >>> migration for VBUFFER data (basically provide migration for a
> >>> sub-buffer) and for locating next in QTAILQ.
> >>>
> >>> The implementation of the VBUFFER feature is broken when VMSTATE_ALLOC
> >>> is used. This however goes unnoticed because actually partial migration
> >>> for VBUFFER is not used at all.
> >>>
> >>> Let's consolidate the usage of VMStateField.start by removing support
> >>> for partial migration for VBUFFER.
> >>>
> >>> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> >>
> >> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >>
> >
> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Thanks for the review Philippe!
>
> @Maintainers: Softfreeze is approaching, and I would like to try
> get my 'array of pointers with null pointers' (which is on top of
> this) in 2.9 too if possible. Anything I can do to speed things up?
It went in on Monday!
Dave
> Regards,
> Halil
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2017-02-15 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 17:52 [Qemu-devel] [PATCH] migration: consolidate VMStateField.start Halil Pasic
2017-02-10 15:24 ` Dr. David Alan Gilbert
2017-02-11 4:26 ` Philippe Mathieu-Daudé
2017-02-15 11:42 ` Halil Pasic
2017-02-15 11:46 ` Dr. David Alan Gilbert [this message]
2017-02-15 11:47 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215114646.GC2731@work-vm \
--to=dgilbert@redhat.com \
--cc=f4bug@amsat.org \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).