From: "Daniel P. Berrange" <berrange@redhat.com>
To: Nir Soffer <nsoffer@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
Maor Lipchuk <mlipchuk@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Allon Mureinik <amureini@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
qemu-discuss@nongnu.org
Subject: Re: [Qemu-devel] Estimation of qcow2 image size converted from raw image
Date: Wed, 15 Feb 2017 16:07:43 +0000 [thread overview]
Message-ID: <20170215160743.GJ24672@redhat.com> (raw)
In-Reply-To: <CAMRbyyv4gGDG1f5tbb8NTtWPdWC+23OT2GKcrLLOuo4N2Prrkg@mail.gmail.com>
On Wed, Feb 15, 2017 at 05:57:12PM +0200, Nir Soffer wrote:
> On Wed, Feb 15, 2017 at 5:20 PM, Daniel P. Berrange <berrange@redhat.com> wrote:
> > On Wed, Feb 15, 2017 at 03:14:19PM +0000, Stefan Hajnoczi wrote:
> >> On Mon, Feb 13, 2017 at 05:46:19PM +0200, Maor Lipchuk wrote:
> >> > I was wondering if that is possible to provide a new API that
> >> > estimates the size of
> >> > qcow2 image converted from a raw image. We could use this new API to
> >> > allocate the
> >> > size more precisely before the convert operation.
> >> >
> >> [...]
> >> > We think that the best way to solve this issue is to return this info
> >> > from qemu-img, maybe as a flag to qemu-img convert that will
> >> > calculate the size of the converted image without doing any writes.
> >>
> >> Sounds reasonable. qcow2 actually already does some of this calculation
> >> internally for image preallocation in qcow2_create2().
> >>
> >> Let's try this syntax:
> >>
> >> $ qemu-img query-max-size -f raw -O qcow2 input.raw
> >> 1234678000
> >>
> >> As John explained, it is only an estimate. But it will be a
> >> conservative maximum.
> >
> > This forces you to have an input file. It would be nice to be able to
> > get the same information by merely giving the desired capacity e.g
> >
> > $ qemu-img query-max-size -O qcow2 20G
>
> Without a file, this will have to assume that all clusters will be allocated.
>
> Do you have a use case for not using existing file?
If you want to format a new qcow2 file in a pre-created block device you
want to know how big the block device should be. Or you want to validate
that the filesystem you're about to created it in will not become
overrcomitted wrt pre-existing guests. So you need to consider the FS
free space, vs query-max-size for all existing guest, combined with
query-max-size for the new disk you wan tto create
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2017-02-15 16:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 15:46 [Qemu-devel] Estimation of qcow2 image size converted from raw image Maor Lipchuk
2017-02-13 17:03 ` John Snow
2017-02-13 17:16 ` Daniel P. Berrange
2017-02-13 18:26 ` John Snow
2017-02-15 15:14 ` Stefan Hajnoczi
2017-02-15 15:20 ` Daniel P. Berrange
2017-02-15 15:34 ` Eric Blake
2017-02-15 15:57 ` Nir Soffer
2017-02-15 16:05 ` [Qemu-devel] [Qemu-discuss] " Alberto Garcia
2017-02-15 16:11 ` Daniel P. Berrange
2017-02-15 16:07 ` Daniel P. Berrange [this message]
2017-02-20 11:12 ` [Qemu-devel] " Stefan Hajnoczi
2017-02-15 15:49 ` Nir Soffer
2017-02-20 11:07 ` Stefan Hajnoczi
[not found] ` <CAJ1JNOdzD7DHTHGJEO2YQANDPq0kY-PEh6J1jBkP7hUW0Kvy9w@mail.gmail.com>
[not found] ` <CAMRbyyssi_rspwDJTtWM1Ju5CTZ15z1xBikRDONrS84rx+B8Qg@mail.gmail.com>
2017-02-22 16:15 ` Maor Lipchuk
2017-02-22 22:06 ` Maor Lipchuk
2017-02-28 9:19 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215160743.GJ24672@redhat.com \
--to=berrange@redhat.com \
--cc=amureini@redhat.com \
--cc=kwolf@redhat.com \
--cc=mlipchuk@redhat.com \
--cc=mreitz@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-discuss@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).