qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Pranith Kumar" <bobby.prani@gmail.com>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [Qemu-devel] [PULL v2 11/14] linux-user: fix tcg/mmap test
Date: Thu, 16 Feb 2017 15:38:13 +0100	[thread overview]
Message-ID: <20170216143816.2384-12-laurent@vivier.eu> (raw)
In-Reply-To: <20170216143816.2384-1-laurent@vivier.eu>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

tests/tcg/mmap test fails with values other than default target page
size. When creating a map beyond EOF, extra anonymous pages are added up
to the target page boundary. Currently, this operation is performed only
when qemu_real_host_page_size < TARGET_PAGE_SIZE, but it should be
performed if the configured page size (qemu -p) is larger than
qemu_real_host_page_size too.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
[pranith: dropped checkpatch changes]
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20170119151533.29328-2-bobby.prani@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/mmap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index 4ed9cad..4888f53 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -426,9 +426,9 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int prot,
        may need to truncate file maps at EOF and add extra anonymous pages
        up to the targets page boundary.  */
 
-    if ((qemu_real_host_page_size < TARGET_PAGE_SIZE)
-        && !(flags & MAP_ANONYMOUS)) {
-       struct stat sb;
+    if ((qemu_real_host_page_size < qemu_host_page_size) &&
+        !(flags & MAP_ANONYMOUS)) {
+        struct stat sb;
 
        if (fstat (fd, &sb) == -1)
            goto fail;
-- 
2.9.3

  parent reply	other threads:[~2017-02-16 14:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 14:38 [Qemu-devel] [PULL v2 00/14] Linux user for upstream patches Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 01/14] linux-user: remove ifdef __USER_MISC Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 02/14] linux-user: drop __cygwin__ ifdef Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 03/14] linux-user: Fix s390x safe-syscall for z900 Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 04/14] linux-user: Fix inotify_init1 support Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 05/14] linux-user: Fix readahead Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 06/14] linux-user: Fix mq_open Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 07/14] linux-user: manage two new IFLA host message types Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 08/14] linux-user: Update sh4 syscall definitions to match Linux 4.8 Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 09/14] linux-user: Update m68k syscall definitions to match Linux 4.6 Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 10/14] linux-user: fix settime old value location Laurent Vivier
2017-02-16 14:38 ` Laurent Vivier [this message]
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 12/14] linux-user: fill target sigcontext struct accordingly Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 13/14] linux-user: Use correct types in load_symbols() Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 14/14] linux-user: Add FICLONE and FICLONERANGE ioctls Laurent Vivier
2017-02-16 16:06 ` [Qemu-devel] [PULL v2 00/14] Linux user for upstream patches Peter Maydell
2017-02-16 16:17   ` Laurent Vivier
2017-02-16 16:21 ` no-reply
2017-02-16 16:22 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170216143816.2384-12-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=bobby.prani@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).