qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>,
	Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>,
	Laurent Vivier <laurent@vivier.eu>
Subject: [Qemu-devel] [PULL v2 12/14] linux-user: fill target sigcontext struct accordingly
Date: Thu, 16 Feb 2017 15:38:14 +0100	[thread overview]
Message-ID: <20170216143816.2384-13-laurent@vivier.eu> (raw)
In-Reply-To: <20170216143816.2384-1-laurent@vivier.eu>

From: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>

A segfault is noticed when an emulated program uses any of ucontext
regs fields. Risu detected this issue in the following operation when
handling a signal:
  ucontext_t *uc = (ucontext_t*)uc;
  uc->uc_mcontext.regs->nip += 4;

but this works fine:
  uc->uc_mcontext.gp_regs[PT_NIP] += 4;

This patch set regs to a valid location as well as other sigcontext
fields.

Signed-off-by: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <1485900317-3256-1-git-send-email-joserz@linux.vnet.ibm.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/signal.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/linux-user/signal.c b/linux-user/signal.c
index 5064de0..8209539 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -5155,6 +5155,7 @@ static void setup_rt_frame(int sig, struct target_sigaction *ka,
     target_ulong rt_sf_addr, newsp = 0;
     int i, err = 0;
 #if defined(TARGET_PPC64)
+    struct target_sigcontext *sc = 0;
     struct image_info *image = ((TaskState *)thread_cpu->opaque)->info;
 #endif
 
@@ -5183,6 +5184,10 @@ static void setup_rt_frame(int sig, struct target_sigaction *ka,
 #if defined(TARGET_PPC64)
     mctx = &rt_sf->uc.tuc_sigcontext.mcontext;
     trampptr = &rt_sf->trampoline[0];
+
+    sc = &rt_sf->uc.tuc_sigcontext;
+    __put_user(h2g(mctx), &sc->regs);
+    __put_user(sig, &sc->signal);
 #else
     mctx = &rt_sf->uc.tuc_mcontext;
     trampptr = (uint32_t *)&rt_sf->uc.tuc_mcontext.tramp;
-- 
2.9.3

  parent reply	other threads:[~2017-02-16 14:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 14:38 [Qemu-devel] [PULL v2 00/14] Linux user for upstream patches Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 01/14] linux-user: remove ifdef __USER_MISC Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 02/14] linux-user: drop __cygwin__ ifdef Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 03/14] linux-user: Fix s390x safe-syscall for z900 Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 04/14] linux-user: Fix inotify_init1 support Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 05/14] linux-user: Fix readahead Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 06/14] linux-user: Fix mq_open Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 07/14] linux-user: manage two new IFLA host message types Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 08/14] linux-user: Update sh4 syscall definitions to match Linux 4.8 Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 09/14] linux-user: Update m68k syscall definitions to match Linux 4.6 Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 10/14] linux-user: fix settime old value location Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 11/14] linux-user: fix tcg/mmap test Laurent Vivier
2017-02-16 14:38 ` Laurent Vivier [this message]
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 13/14] linux-user: Use correct types in load_symbols() Laurent Vivier
2017-02-16 14:38 ` [Qemu-devel] [PULL v2 14/14] linux-user: Add FICLONE and FICLONERANGE ioctls Laurent Vivier
2017-02-16 16:06 ` [Qemu-devel] [PULL v2 00/14] Linux user for upstream patches Peter Maydell
2017-02-16 16:17   ` Laurent Vivier
2017-02-16 16:21 ` no-reply
2017-02-16 16:22 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170216143816.2384-13-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=joserz@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).